Re: Fix SWSUSP & !SWAP

Geert Uytterhoeven
2003-04-24T11:25:35Z

On Thu, 24 Apr 2003, Nigel Cunningham wrote:
> On Thu, 2003-04-24 at 21:46, Andrew Morton wrote:
> > > > Sorry, I still don't get it. Go through the steps for me:
> > > >
> > > > 1) suspend writes pages to disk
> > > >
> > > > 2) machine is shutdown
> > > >
> > > > 3) restart, journal replay
>
> Corruption comes here. The journal reply tidies things up that shouldn't
> be tidied up. They shouldn't be tidied up because once we reload the
> image, things should be in the same state as prior to suspend. If replay
> frees a block (thinking it wasn't properly linked or something similar),
> it introduces corruption.

This has nothing to do with using a swapfile.

But if you resume from swsusp, you don't really `mount' all file systems. They
are implicitly mounted because they were mounted before the suspend operation.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds