linux-2.5.68-bk8: Problem with "make xconfig"

linux-2.5.68-bk8: Problem with "make xconfig"

[Karl Weigel]

Hello Roman,


I have difficulties with configuring the kernel with "make xconfig":

  g++ -Wp,-MD,scripts/kconfig/.qconf.o.d -O2  -I/usr/lib/qt3/include  -c -o 
scripts/kconfig/qconf.o scripts/kconfig/qconf.cc
scripts/kconfig/qconf.cc: In destructor `virtual ConfigItem::~ConfigItem()':
scripts/kconfig/qconf.cc:291: error: non-lvalue in unary `&'
make[1]: *** [scripts/kconfig/qconf.o] Fehler 1
make: *** [scripts/kconfig/qconf] Fehler 2


After changing the offending line, it did compile and I was able to configure 
the kernel. However, I am not really sure, whether this change is correct:

--- scripts/kconfig/qconf.cc~   2003-03-17 22:43:38.000000000 +0100
+++ scripts/kconfig/qconf.cc    2003-04-29 11:07:57.000000000 +0200
@@ -288,7 +288,7 @@
 ConfigItem::~ConfigItem(void)
 {
        if (menu) {
-               ConfigItem** ip = &(ConfigItem*)menu->data;
+               ConfigItem** ip = (ConfigItem**)&(menu->data);
                for (; *ip; ip = &(*ip)->nextItem) {
                        if (*ip == this) {
                                *ip = nextItem;


My environment is SuSE Linux 8.2 and GCC 3.3
g++ --version
g++ (GCC) 3.3 20030226 (prerelease) (SuSE Linux)
Copyright (C) 2002 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


I would like to know, whether this modification would be correct with you.


Regards
Karl