public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: viro@parcelfarce.linux.theplanet.co.uk
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KernelJanitor: Convert remaining error returns to return -E Linux 2.5.68
Date: Wed, 30 Apr 2003 01:02:36 +0100	[thread overview]
Message-ID: <20030430000236.GS10374@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20030429161128.3b8c762b.rddunlap@osdl.org>

On Tue, Apr 29, 2003 at 04:11:28PM -0700, Randy.Dunlap wrote:
> On Tue, 29 Apr 2003 23:08:30 +0000 Gabriel Devenyi <devenyga@mcmaster.ca> wrote:
> 
> | Thanks for the suggestions, I'm kinda new at this and just following the TODO 
> | which unfortuately says "sed s/return EWHATEVER/return -EWHATEVER/". I'll 
> | work on checking the things you suggested. As for your other questions, the 
> | kernel did build but I didn't attempt to boot it, I'll be sure to do so in 
> | the future. Thanks for the encouragement.
> | 
> | P.S. Anyone who works on KernelJanitor, kj.pl is suggesting some of the things 
> | I'm changing which aparently I shouldn't.
> 
> 
> The kernel-janitor TODO should be your guide.  However, it needs some
> updating too, so the best thing to do is ask about things on
> kernel-janitor-discuss@lists.sf.net before you spend time on them.
> 
> [item updates are welcome]

Well...  Turn that one into
	* try and convince XFS folks that they want to use negative numbers
for error values (will be tricky - they really don't like to diverge from
IRIX codebase)
	* ditto for JFS - again, a bunch of functions use positive error
values.
	* oprofile init on alpha should be returning negative in case of
failure to follow the common conventions.

AFAICS that's it.

  reply	other threads:[~2003-04-29 23:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-29 23:11 [PATCH] KernelJanitor: Convert remaining error returns to return -E Linux 2.5.68 Randy.Dunlap
2003-04-30  0:02 ` viro [this message]
2003-04-30  0:25   ` John Levon
2003-04-30 14:19   ` Dave Kleikamp
2003-05-01  4:12   ` Randy.Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2003-04-29 22:15 Gabriel Devenyi
2003-04-29 22:32 ` Randy.Dunlap
2003-04-29 23:08   ` Gabriel Devenyi
2003-04-30  0:22     ` Dave Jones
2003-04-29 22:42 ` viro
2003-04-29 23:11   ` Gabriel Devenyi
2003-05-05 22:11     ` Pavel Machek
2003-05-05 22:22       ` viro
2003-05-05 22:33         ` Martin Mares

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030430000236.GS10374@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox