Re: [PATCH] KernelJanitor: Convert remaining error returns to return -E Linux 2.5.68

Gabriel Devenyi
2003-04-29T23:00:11Z

It was intended to do exactly what the KernelJanitor TODO and kj.pl script
pointed out, but aparently there's more to it than that. (BTW it just says
"sed s/return EWHATEVER/return -EWHATEVER/") Discouraging people with foul
language isn't the best way to get more developers, this is only my first
try.

--
Building the Future,
Gabriel Devenyi
devenyga@mcmaster.ca

On April 29, 2003 10:42 pm, you wrote:
> On Tue, Apr 29, 2003 at 10:15:20PM +0000, Gabriel Devenyi wrote:
> > This patch applies to 2.5.68. It converts all the remaining error returns
> > to the new return -E form, this is in the KernelJanitor TODO list.
> >
> > http://muss.mcmaster.ca/~devenyga/patch-linux-2.5.68-return-errors.patch
> >
> > Please CC me with any discussion since I do not subscribe to lkml
>
> Have you tried to compile the patched kernel?
>
> Patch is bogus - most of the changes are s/return ERR_PTR(foo)/return foo/
> with neither explanation nor change of function prototype not change of
> other exits from these functions.
>
> WTF was it intended to do?

--
Building the Future,
Gabriel Devenyi
devenyga@mcmaster.ca