From: Ben Collins <bcollins@debian.org>
To: Grzegorz Jaskiewicz <gj@pointblue.com.pl>
Cc: lkml <linux-kernel@vger.kernel.org>, Linus <torvalds@transmeta.com>
Subject: Re: [PATCH] ieee1394.c on - compilation errors
Date: Wed, 30 Apr 2003 18:43:46 -0400 [thread overview]
Message-ID: <20030430224346.GA372@phunnypharm.org> (raw)
In-Reply-To: <1051743594.5267.7.camel@flat41>
On Wed, Apr 30, 2003 at 11:59:54PM +0100, Grzegorz Jaskiewicz wrote:
> Hello there!
>
> Another trivial, monkeys job patch.
>
> Anyway, it is good to look at some changes and learn :)
>
Please inspect the logic before removing things :)
I already submitted a patch to Linus to fix this. The problem is that
class_num was used as an opaque way of determining what sort of device
(host/node/unitdir) it was dealing with on the ieee1394 bus. Your patch
would likely cause a lot of oopses.
--
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo - http://www.deqo.com/
next prev parent reply other threads:[~2003-04-30 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-30 22:59 [PATCH] ieee1394.c on - compilation errors Grzegorz Jaskiewicz
2003-04-30 22:43 ` Ben Collins [this message]
2003-04-30 23:13 ` Grzegorz Jaskiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030430224346.GA372@phunnypharm.org \
--to=bcollins@debian.org \
--cc=gj@pointblue.com.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox