From: Andi Kleen <ak@muc.de>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Andi Kleen <ak@muc.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix prefetch patching in 2.5-bk
Date: Thu, 1 May 2003 03:51:48 +0200 [thread overview]
Message-ID: <20030501015148.GB3616@averell> (raw)
In-Reply-To: <Pine.LNX.4.44.0304301814010.20283-100000@home.transmeta.com>
On Thu, May 01, 2003 at 03:21:52AM +0200, Linus Torvalds wrote:
> and making "sourcelen==0" a special case for replacement (replace with the
> proper destination length nop, instead of having that "0x90 0x90 0x90"
> sequence).
Note sure what you mean with 0x90 sequence.
My original implementation used .rept to generate the correct number of
(single byte) nops based on the label length of the other case.
But it didn't work because I ran into at least one weird assembler bug (it internally
got confused on something and gave an impossible error message about a
missing label). Also it only generated single byte nops.
In any case you need to pad the code to the correct number of bytes,
I'm not sure how it can be done otherwise.
-Andi
prev parent reply other threads:[~2003-05-01 1:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-01 0:15 [PATCH] Fix prefetch patching in 2.5-bk Andi Kleen
2003-05-01 1:21 ` Linus Torvalds
2003-05-01 1:51 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030501015148.GB3616@averell \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox