Re: Remains of seq_file conversion for DECnet, plus fixes

[Arnaldo Carvalho de Melo <acme@conectiva.com.br>]

Em Thu, May 01, 2003 at 02:22:35PM -0700, David S. Miller escreveu:
>    From: Steven Whitehouse <steve@gw.chygwyn.com>
>    Date: Thu, 1 May 2003 22:35:46 +0100 (BST)

>    > The name is a bit generic for an export function.  What about
>    > seq_release_kfree?

>    Yes, I'd considered that and eventually settled for the non-prefixed
>    version since it followed the pattern set by single_release() which
>    doesn't have the seq_ prefix. I don't mind changing it though if the
>    prefixed version is preferred,
 
> I think a naming convention without a prefix is asking for
> trouble.  I'd ask that you add the prefix, the current convention
> is troublesome and someone ought to clean that up.

Agreed, I also tought of adding it as a generic function, that is the spirit
of ip_seq_release, that is already used several net/ipv4 seq_file routines
and should be deleted in favour of seq_release_private, that is my preferred
name, as it is more general.

- Arnaldo