public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.5 patch] kill the last occurances of usb_serial_get_by_minor
@ 2003-05-02 15:37 Adrian Bunk
  2003-05-02 16:04 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2003-05-02 15:37 UTC (permalink / raw)
  To: viro, Greg KH; +Cc: linux-kernel

I got an error at the final linking of 2.5.68-bk11. It seems the patch 
below is needed.

cu
Adrian


--- linux-2.5.68-bk11/drivers/usb/serial/console.c.old	2003-05-02 17:27:06.000000000 +0200
+++ linux-2.5.68-bk11/drivers/usb/serial/console.c	2003-05-02 17:27:34.000000000 +0200
@@ -133,7 +133,7 @@
 	co->cflag = cflag;
 
 	/* grab the first serial port that happens to be connected */
-	serial = usb_serial_get_by_minor (0);
+	serial = usb_serial_get_by_index(0);
 	if (serial_paranoia_check (serial, __FUNCTION__)) {
 		/* no device is connected yet, sorry :( */
 		err ("No USB device connected to ttyUSB0");
--- linux-2.5.68-bk11/drivers/usb/serial/usb-serial.h.old	2003-05-02 17:27:43.000000000 +0200
+++ linux-2.5.68-bk11/drivers/usb/serial/usb-serial.h	2003-05-02 17:28:13.000000000 +0200
@@ -280,7 +280,7 @@
 #endif
 
 /* Functions needed by other parts of the usbserial core */
-extern struct usb_serial *usb_serial_get_by_minor (unsigned int minor);
+extern struct usb_serial *usb_serial_get_by_index (unsigned int minor);
 extern int usb_serial_generic_open (struct usb_serial_port *port, struct file *filp);
 extern int usb_serial_generic_write (struct usb_serial_port *port, int from_user, const unsigned char *buf, int count);
 extern void usb_serial_generic_close (struct usb_serial_port *port, struct file *filp);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [2.5 patch] kill the last occurances of usb_serial_get_by_minor
  2003-05-02 15:37 [2.5 patch] kill the last occurances of usb_serial_get_by_minor Adrian Bunk
@ 2003-05-02 16:04 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2003-05-02 16:04 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: viro, linux-kernel

On Fri, May 02, 2003 at 05:37:23PM +0200, Adrian Bunk wrote:
> I got an error at the final linking of 2.5.68-bk11. It seems the patch 
> below is needed.

Heh, you're using USB_SERIAL_CONSOLE?  crazy...

Anyway, yes, you're right.  I'll add this to my tree and send it off to
Linus in my next round of patches.  Thanks a lot for finding this and
the patch.

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-05-02 15:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-02 15:37 [2.5 patch] kill the last occurances of usb_serial_get_by_minor Adrian Bunk
2003-05-02 16:04 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox