From: Ben Collins <bcollins@debian.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] alternative compat_ioctl table implementation
Date: Fri, 2 May 2003 14:09:41 -0400 [thread overview]
Message-ID: <20030502180941.GG426@phunnypharm.org> (raw)
In-Reply-To: <200305021959.02726.arnd@arndb.de>
On Fri, May 02, 2003 at 07:59:02PM +0200, Arnd Bergmann wrote:
> I had some trouble making the 2.5.68bk implementation
> for compat_ioctl work on s390x because of a cross-compiling
> bug in gcc-2.95.
>
> This patch changes the way that the translation table
> is generated and solves the problem by replacing
> the assembler magic with linker magic.
>
> As a side effect, it adds type-checking for the handler
> functions and makes it possible to put COMPATIBLE_IOCTL()
> in places other than arch/*/kernel/ioctl32.c, e.g. next
> to the normal ioctl handler.
>
> This needs the compat-ioctl-fix.patch from 2.5.68mm4.
>
You macros don't work for things like this:
COMPATIBLE_IOCTL(_IOW('v', BASE_VIDIOCPRIVATE+0, char [256]))
COMPATIBLE_IOCTL(_IOR('v', BASE_VIDIOCPRIVATE+1, char [256]))
...which are in compat_ioctl.h.
--
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
Deqo - http://www.deqo.com/
next prev parent reply other threads:[~2003-05-02 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-02 17:59 [PATCH] alternative compat_ioctl table implementation Arnd Bergmann
2003-05-02 18:09 ` Ben Collins [this message]
[not found] <200305021959.02726.arnd@arndb.de.suse.lists.linux.kernel>
2003-05-02 18:09 ` Andi Kleen
2003-05-02 21:42 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030502180941.GG426@phunnypharm.org \
--to=bcollins@debian.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox