From: Christoph Hellwig <hch@lst.de>
To: "René Scharfe" <l.s.r@web.de>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Re: [PATCH 2.5] [TRIVIAL] Get rid of magic numbers in drivers/block/genhd.c
Date: Sun, 4 May 2003 07:55:02 +0200 [thread overview]
Message-ID: <20030504075502.A6915@lst.de> (raw)
In-Reply-To: <20030504000425.726daf8b.l.s.r@web.de>; from l.s.r@web.de on Sun, May 04, 2003 at 12:04:25AM +0200
On Sun, May 04, 2003 at 12:04:25AM +0200, René Scharfe wrote:
> Hi Christoph,
>
> a few days ago you cleaned up disk_name() in fs/partitions/check.c. It
> is now guaranteed to write no more than BDEVNAME_SIZE into the provided
> buffer.
>
> There are two buffers in drivers/block/genhd.c, that are used solely for
> calling disk_name(), and have a size of 64. The patch below replaces
> these magic numbers with BDEVNAME_SIZE.
>
> Additionally it corrects the comment at the top of disk_name(): The md
> driver does not call that function, the genhd driver does.
Looks fine to me.
Rusty, is the trivial patch bot still active? I haven't seen Marcelo
or Linus merging trivial patches for ages (or maybe I've missed
something?)
next prev parent reply other threads:[~2003-05-04 5:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-03 22:04 [PATCH 2.5] [TRIVIAL] Get rid of magic numbers in drivers/block/genhd.c René Scharfe
2003-05-04 5:55 ` Christoph Hellwig [this message]
2003-05-05 4:42 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030504075502.A6915@lst.de \
--to=hch@lst.de \
--cc=l.s.r@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox