Re: [PATCH] remove useless MOD_{INC,DEC}_USE_COUNT from sunrpc

David S. Miller
2003-05-04T20:46:46Z

On Sun, 2003-05-04 at 12:00, Trond Myklebust wrote:
> >>>>> " " == Christoph Hellwig <hch@lst.de> writes:
>
> > Previously you incremented the usecount and now we're waiting
> > for the thread to finish in module_exit().
>
> Fair enough...

Well, what if this hangs? Unless the user specifies
"--wait" to 2.5.x's rmmod, the user absolutely does not
expect this behavior.

Rather, so that the "--wait" is respected, something one level
up ought to be doing try_module_get().

If you want to change the behavior, that's definitely to be considered,
but on a global scale not locally for sunrpc.

--
David S. Miller <davem@redhat.com>