From: Christoph Hellwig <hch@infradead.org>
To: Michael Hunold <hunold@convergence.de>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH[[2.5][6-11] add a new dvb frontend driver
Date: Tue, 6 May 2003 21:51:50 +0100 [thread overview]
Message-ID: <20030506215150.B18262@infradead.org> (raw)
In-Reply-To: <3EB7DF1A.4030906@convergence.de>; from hunold@convergence.de on Tue, May 06, 2003 at 06:13:14PM +0200
On Tue, May 06, 2003 at 06:13:14PM +0200, Michael Hunold wrote:
> +#include <asm/errno.h>
always use linux/errno.h, not asm/errno.h
> +#include <linux/slab.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/init.h>
> +
> +#include "dvb_frontend.h"
> +#include "dvb_functions.h"
> +
> +static int debug = 0;
This is in .bss, no need to initialize.
> +#define dprintk if (debug) printk
Every heard of do { foo } while (0) ;)
> +static
> +struct dvb_frontend_info cx24110_info = {
> + name: "Conexant CX24110 with CX24108 tuner, aka HM1221/HM1811",
> + type: FE_QPSK,
Please use C99 initializers, also the static is positioned very strange..
prev parent reply other threads:[~2003-05-06 20:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-06 16:13 [PATCH[[2.5][6-11] add a new dvb frontend driver Michael Hunold
2003-05-06 20:51 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030506215150.B18262@infradead.org \
--to=hch@infradead.org \
--cc=hunold@convergence.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox