Typo in arch/sh/kernel/io_7751se.c

Typo in arch/sh/kernel/io_7751se.c

[Paul van Gool]

Hi,

not sure who to send it to. So as suggested in REPORTING-BUGS, I'm sending
it to this mailing list.

While building a kernel for an SH7751 SolutionEngine, I ran into a link
problem using a non-PCI configuration. I tracked the problem back to
arch/sh/kernel/io_7751se.c. On line 304, I see:

#if defined(CONFIG_PCI)
#define CHECK_SH7751_PCIIO(port) \
  ((port >= PCIBIOS_MIN_IO) && (port < (PCIBIOS_MIN_IO + SH7751_PCI_IO_SIZE)))
#else
#define CHECK_SH_7751_PCIIO(port) (0)
#endif

The problem is with the 5th line. It should be:

#define CHECK_SH7751_PCIIO(port) (0)

I removed the '_' between SH and 7751.

If I need to send this somewhere else, please tell me where.

Thanks.

Paul
-- 
Paul van Gool                                               Rincon Networks
paul.vangool@rinconnetworks.com                              (805)-705-1442

Re: Typo in arch/sh/kernel/io_7751se.c

[Paul Mundt]

On Tue, May 06, 2003 at 07:46:47PM -0700, Paul van Gool wrote:
> not sure who to send it to. So as suggested in REPORTING-BUGS, I'm sending
> it to this mailing list.
> 
Please send all SH related bugs to linuxsh-dev@lists.sourceforge.net.
Consult MAINTAINERS for additional links.

> While building a kernel for an SH7751 SolutionEngine, I ran into a link
> problem using a non-PCI configuration. I tracked the problem back to
> arch/sh/kernel/io_7751se.c. On line 304, I see:
> 
> #if defined(CONFIG_PCI)
> #define CHECK_SH7751_PCIIO(port) \
>   ((port >= PCIBIOS_MIN_IO) && (port < (PCIBIOS_MIN_IO + SH7751_PCI_IO_SIZE)))
> #else
> #define CHECK_SH_7751_PCIIO(port) (0)
> #endif
> 
> The problem is with the 5th line. It should be:
> 
> #define CHECK_SH7751_PCIIO(port) (0)
> 
> I removed the '_' between SH and 7751.
> 
This issue has already been fixed in the LinuxSH CVS for both 2.4 and
2.5. Since I just synced 2.5 over, I guess its time for a 2.4 update..

Re: Typo in arch/sh/kernel/io_7751se.c

[Paul van Gool]

Thanks, Paul.

Paul

On Tue, May 06, 2003 at 08:49:38PM -0600, Paul Mundt wrote:
> On Tue, May 06, 2003 at 07:46:47PM -0700, Paul van Gool wrote:
> > not sure who to send it to. So as suggested in REPORTING-BUGS, I'm sending
> > it to this mailing list.
> > 
> Please send all SH related bugs to linuxsh-dev@lists.sourceforge.net.
> Consult MAINTAINERS for additional links.
> 
> > While building a kernel for an SH7751 SolutionEngine, I ran into a link
> > problem using a non-PCI configuration. I tracked the problem back to
> > arch/sh/kernel/io_7751se.c. On line 304, I see:
> > 
> > #if defined(CONFIG_PCI)
> > #define CHECK_SH7751_PCIIO(port) \
> >   ((port >= PCIBIOS_MIN_IO) && (port < (PCIBIOS_MIN_IO + SH7751_PCI_IO_SIZE)))
> > #else
> > #define CHECK_SH_7751_PCIIO(port) (0)
> > #endif
> > 
> > The problem is with the 5th line. It should be:
> > 
> > #define CHECK_SH7751_PCIIO(port) (0)
> > 
> > I removed the '_' between SH and 7751.
> > 
> This issue has already been fixed in the LinuxSH CVS for both 2.4 and
> 2.5. Since I just synced 2.5 over, I guess its time for a 2.4 update..

-- 
Paul van Gool                                               Rincon Networks
paul.vangool@rinconnetworks.com                              (805)-705-1442