Re: ioctl cleanups: enable sg_io and serial stuff to be shared

Pavel Machek
2003-05-07T15:18:56Z

Hi!

> > > > Only change *needed* in each architecture is moving A() macros into
> > > > compat.h, so that generic code can use it. Please apply,
> > >
> > > Please don't use A() in new code, we now have compat_ptr() and
> > > compat_uptr_t for this.
> >
> > Fixed now.
>
> Btw, if you really want to move all the 32bit ioctl compat code to the
> drivers a ->ioctl32 file operation might be the better choice..

Not sure if we are not too close to stable release to do that? And I
see no incremental way how to get there. Moving compatibility stuff
closer to drivers can be done close to stable release...

OTOH it forces pain where it belongs, and when someone invents stupid
ioctl, it puts pain on him... I like that.

Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]