From: Christoph Hellwig <hch@infradead.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: chas williams <chas@locutus.cmf.nrl.navy.mil>,
davem@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [ATM] [PATCH] unbalanced exit path in Forerunner HE he_init_one()
Date: Thu, 8 May 2003 06:06:40 +0100 [thread overview]
Message-ID: <20030508060640.A24325@infradead.org> (raw)
In-Reply-To: <20030508010146.A20715@electric-eye.fr.zoreil.com>; from romieu@fr.zoreil.com on Thu, May 08, 2003 at 01:01:46AM +0200
On Thu, May 08, 2003 at 01:01:46AM +0200, Francois Romieu wrote:
> #if LINUX_VERSION_CODE > KERNEL_VERSION(2,3,43)
> - if (pci_enable_device(pci_dev)) return -EIO;
> + if (pci_enable_device(pci_dev))
> + goto out;
> #endif
Btw, this driver badly wants a cleanup of the ifdef mess. Look
at some network drivers on how to support older kenrels nicely
wiþh not much more than a compat layer header instead of spreading
ifdefs all over the place. Who reviewed this driver before
inclusion?
next prev parent reply other threads:[~2003-05-08 4:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200305071813.h47IDpc9010906@hera.kernel.org>
2003-05-07 23:01 ` [ATM] [PATCH] unbalanced exit path in Forerunner HE he_init_one() Francois Romieu
2003-05-08 5:06 ` Christoph Hellwig [this message]
2003-05-08 10:08 ` Francois Romieu
2003-05-08 10:54 ` David S. Miller
2003-05-08 22:47 ` Werner Almesberger
2003-05-09 0:58 ` chas williams
2003-05-09 1:23 ` David S. Miller
2003-05-09 22:02 ` [ATM] [UPDATE] " Francois Romieu
2003-05-09 23:38 ` [ATM] [UPDATE] unbalanced exit path in Forerunner HE he_init_one() (and an iphase patch too!) chas williams
2003-05-10 5:20 ` Christoph Hellwig
2003-05-10 13:52 ` chas williams
2003-05-10 14:02 ` David S. Miller
2003-05-10 15:18 ` chas williams
2003-05-10 15:25 ` David S. Miller
2003-05-10 14:43 ` Christoph Hellwig
2003-05-10 16:12 ` Greg KH
2003-05-10 19:39 ` [USB] [PATCH] Crud-- (was: Re: [ATM] [UPDATE] unbalanced usw) Francois Romieu
2003-05-10 21:01 ` Francois Romieu
2003-05-10 23:04 ` Francois Romieu
2003-05-13 20:10 ` Greg KH
2003-05-10 10:54 ` [ATM] [UPDATE] unbalanced exit path in Forerunner HE he_init_one() (and an iphase patch too!) Francois Romieu
2003-05-08 12:20 ` [ATM] [PATCH] unbalanced exit path in Forerunner HE he_init_one() chas williams
2003-05-08 13:18 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030508060640.A24325@infradead.org \
--to=hch@infradead.org \
--cc=chas@locutus.cmf.nrl.navy.mil \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox