[patch] set argv[0] of init process to filename

[patch] set argv[0] of init process to filename

[Glenn McGrath]

[-- Attachment #1.1: Type: text/plain, Size: 656 bytes --]


In init/main.c the kernel always sets argv[0] = "init" when calling the
init process.

The file being executed as init is commonly /sbin/init, but could be
anything, as set from init= boot paramater.

Always setting argv[0] = "init" is inconsistent with standard behaviour
of setting it to the filename that was run.

This current behaviour is inconvenient for busybox (www.busybox.net) as
it uses argv[0] to determine functionality.

The attached patch against 2.4.20 sets argv[0] to the filename being run
as the init process, it results in marginally smaller binary (12 bytes).

Is there a reason why argv[0] should always be set to "init" ?



Glenn 

[-- Attachment #1.2: init_argv.diff.gz --]
[-- Type: application/octet-stream, Size: 906 bytes --]

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [patch] set argv[0] of init process to filename

[DervishD]

    Hi Glenn :)

* Glenn McGrath <bug1@optushome.com.au> dixit:
> This current behaviour is inconvenient for busybox
> (www.busybox.net) as it uses argv[0] to determine functionality.

    I had a similar problem with my init clone (a virtual console
init+getty+login for embedded systems) with the same issue. I wanted
to change the argv[0] for spawned processes for chaging the name that
the ps command will show. At the end I assumed that the shortest name
possible was 'init' and that I had four characters at least... If the
space is shorter, less characters are used.

> The attached patch against 2.4.20 sets argv[0] to the filename
> being run as the init process, it results in marginally smaller
> binary (12 bytes).

    IMHO this is a good thing, I hope it gets included, since in the
general case it won't do any harm (IMHO, again). Let's see what says
Marcelo.

> Is there a reason why argv[0] should always be set to "init" ?

    Don't know :??

    Raúl Núñez de Arenas Coronado

-- 
Linux Registered User 88736
http://www.pleyades.net & http://raul.pleyades.net/