From: Dave Peterson <dsp@llnl.gov>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: linux-kernel@vger.kernel.org, axboe@suse.de, davej@suse.de
Subject: Re: [PATCH] fixes for linked list bugs in block I/O code
Date: Thu, 8 May 2003 10:47:24 -0700 [thread overview]
Message-ID: <200305081047.24908.dsp@llnl.gov> (raw)
In-Reply-To: <Pine.SOL.4.30.0305080311330.21696-100000@mion.elka.pw.edu.pl>
On Wednesday 07 May 2003 06:17 pm, Bartlomiej Zolnierkiewicz wrote:
> > > Yes, but bio->bi_next is a NULL already.
> >
> > I think assuming this is bad programming form. You are assuming that
> > the memory allocator zeros out newly allocated memory. Though your
>
> No, it is not memory allocator but block layer.
> Look at bio_init(), there is bio->bi_next = NULL explicitly.
Ok, I agree: the patch is not needed for 2.5 (although I think it still
makes sense for 2.4.20). Thanks for the correction.
-Dave
next prev parent reply other threads:[~2003-05-08 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-07 23:22 [PATCH] fixes for linked list bugs in block I/O code Dave Peterson
2003-05-07 23:42 ` Bartlomiej Zolnierkiewicz
2003-05-08 0:09 ` Dave Peterson
2003-05-08 0:26 ` Bartlomiej Zolnierkiewicz
2003-05-08 0:38 ` Dave Peterson
2003-05-08 1:17 ` Bartlomiej Zolnierkiewicz
2003-05-08 17:47 ` Dave Peterson [this message]
2003-05-08 6:29 ` Jens Axboe
2003-05-08 18:06 ` Dave Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305081047.24908.dsp@llnl.gov \
--to=dsp@llnl.gov \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=axboe@suse.de \
--cc=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox