From: Adrian Bunk <bunk@fs.tum.de>
To: linux-kernel@vger.kernel.org
Cc: trivial@rustcorp.com.au
Subject: [2.5 patch] fix miropcm20-rds.c compilation (fwd)
Date: Thu, 8 May 2003 20:53:50 +0200 [thread overview]
Message-ID: <20030508185350.GS9794@fs.tum.de> (raw)
The issue described in the mail forwarded below is still present in 2.5.
Please apply the patch
Adrian
----- Forwarded message from Adrian Bunk <bunk@fs.tum.de> -----
Date: Fri, 2 May 2003 00:15:52 +0200
From: Adrian Bunk <bunk@fs.tum.de>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org
Subject: [2.5 patch] fix miropcm20-rds.c compilation
The removal of #include <linux/devfs_fs_kernel.h> broke the compilation
of drivers/media/radio/miropcm20-rds.c.old in 2.5.68-bk11:
<-- snip -->
...
gcc-2.95 -Wp,-MD,drivers/media/radio/.miropcm20-rds.o.d -D__KERNEL__
-Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6
-Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include -DKBUILD_BASENAME=miropcm20_rds
-DKBUILD_MODNAME=miropcm20_rds -c -o drivers/media/radio/miropcm20-rds.o
drivers/media/radio/miropcm20-rds.c
drivers/media/radio/miropcm20-rds.c:23: warning: `struct inode' declared
inside parameter list
drivers/media/radio/miropcm20-rds.c:23: warning: its scope is only this
definition or declaration, which is probably not what you want.
drivers/media/radio/miropcm20-rds.c:38: warning: `struct inode' declared
inside parameter list
drivers/media/radio/miropcm20-rds.c:106: variable `rds_fops' has
initializer but incomplete type
drivers/media/radio/miropcm20-rds.c:107: unknown field `owner' specified
in initializer
drivers/media/radio/miropcm20-rds.c:107: warning: excess elements in
struct initializer
drivers/media/radio/miropcm20-rds.c:107: warning: (near initialization
for `rds_fops')
drivers/media/radio/miropcm20-rds.c:108: unknown field `read' specified
in initializer
drivers/media/radio/miropcm20-rds.c:108: warning: excess elements in
struct initializer
drivers/media/radio/miropcm20-rds.c:108: warning: (near initialization
for `rds_fops')
drivers/media/radio/miropcm20-rds.c:109: unknown field `open' specified
in initializer
drivers/media/radio/miropcm20-rds.c:109: warning: excess elements in
struct initializer
drivers/media/radio/miropcm20-rds.c:109: warning: (near initialization
for `rds_fops')
drivers/media/radio/miropcm20-rds.c:110: unknown field `release'
specified in initializer
drivers/media/radio/miropcm20-rds.c:111: warning: excess elements in
struct initializer
drivers/media/radio/miropcm20-rds.c:111: warning: (near initialization
for `rds_fops')
make[3]: *** [drivers/media/radio/miropcm20-rds.o] Error 1
<-- snip -->
The fix is simple:
--- linux-2.5.68-bk11/drivers/media/radio/miropcm20-rds.c.old 2003-05-02 00:07:45.000000000 +0200
+++ linux-2.5.68-bk11/drivers/media/radio/miropcm20-rds.c 2003-05-02 00:11:01.000000000 +0200
@@ -13,6 +13,7 @@
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/miscdevice.h>
+#include <linux/fs.h>
#include <asm/uaccess.h>
#include "miropcm20-rds-core.h"
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
----- End forwarded message -----
reply other threads:[~2003-05-08 18:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030508185350.GS9794@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox