Re: [PATCH] 2.5 ide 48-bit usage

Linus Torvalds
2003-05-08T16:15:23Z

On Thu, 8 May 2003, Jens Axboe wrote:
>
> Maybe a define or two would help here. When you see drive->addressing
> and hwif->addressing, you assume that they are used identically. That
> !hwif->addressing means 48-bit is ok, while !drive->addressing means
> it's not does not help at all.

Why not just change the names? The current setup clearly is confusing, and
adding defines doesn't much help. Rename the structure member so that the
name says what it is, aka "address_mode", and when renaming it you'd go
through the source anyway and change "!addressing" to something more
readable like "address_mode == IDE_LBA48" or whatever.

(Anyway, I'll just drop all the 48-bit patches for now, since you've
totally confused me about which ones are right and what the bugs are ;)

Linus