public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: davem@redhat.com, kernel list <linux-kernel@vger.kernel.org>, ak@suse.de
Subject: ioctl32_unregister_conversion & modules
Date: Fri, 9 May 2003 11:32:51 +0200	[thread overview]
Message-ID: <20030509093250.GA638@elf.ucw.cz> (raw)

Hi!

...what is the problem?

It seems that function pointers into modules do not need any special
treatmeant [I *know* there was talk about this on l-k; but I can't
find anything in Documentation/]:

                if (!capable(CAP_SYS_ADMIN))
                        return -EACCES;
                if (disk->fops->ioctl) {
                        ret = disk->fops->ioctl(inode, file, cmd, arg);
                        if (ret != -EINVAL)
                                return ret;
                }

So... what's the problem with {un}register_ioctl32_conversion being
called from module_init/module_exit? Drivers in the tree do it
already...
								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

             reply	other threads:[~2003-05-09  9:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-09  9:32 Pavel Machek [this message]
     [not found] <20030509100039$6904@gated-at.bofh.it>
2003-05-09 12:10 ` ioctl32_unregister_conversion & modules Arnd Bergmann
2003-05-09 15:24   ` Pavel Machek
2003-05-09 16:13     ` David S. Miller
2003-05-09 17:11       ` Pavel Machek
2003-05-09 17:16         ` David S. Miller
2003-05-09 19:30     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030509093250.GA638@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=ak@suse.de \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox