Re: Linking error in sounddrivers.o (2.4.20)

[Muli Ben-Yehuda <mulix@mulix.org>]

[-- Attachment #1: Type: text/plain, Size: 2691 bytes --]

On Sat, May 10, 2003 at 09:30:29AM -0400, Olivier Dragon wrote:
> On Sat, May 10, 2003 at 10:52:20AM +0300, Muli Ben-Yehuda wrote:
> > Does it still happen with 2.4.21-rc2? Also, could you please send me
> > in private the .config? I get a 504 gateway error when trying to wget
> > it. 
> > That's a fairly experimental kernel for compiling kernels. You might
> > want to stick with 2.95 for the time being. 
> 
> Ok, I've compiled 2.4.21-rc2 (make dep; make bzImage) with 2.95 and I
> got rid of the compilation error (most likely gcc bug) but I still get
> the same linking error as previously mentioned. See below:

The linking error happens because you have 

CONFIG_SOUND_TRIDENT=y
and 
CONFIG_INPUT_PCIGAME=m 

trident.c will call pcigame_attach(), which is either defined or a
nop, depending on whether CONFIG_INPUT_PCIGAME is defined or not. In
your .config it's defined, but as a module. So the call to
pcigame_attach() is trident is defined. But trident is built in, so
when the linker tries to link everything together, it fails because it
cannot find the code for pcigame_attach. It can't find it, since it's
compiled as a module, and thus not linked into the bzImage. 

As a quick fix, you can either make trident a module, or make pcigame
built in, or remove pcigame, if you don't have a joystick
attached. This fairly ugly untested patch against 2.4.21-rc2 should
enforce the dependencies between trident and pcigame. 

diff -Naur 2.4.21-rc2.vanilla/drivers/sound/Config.in 2.4.21-rc2.mx/drivers/sound/Config.in
--- 2.4.21-rc2.vanilla/drivers/sound/Config.in	2003-05-10 18:44:54.000000000 +0300
+++ 2.4.21-rc2.mx/drivers/sound/Config.in	2003-05-10 18:40:15.000000000 +0300
@@ -70,7 +70,14 @@
     dep_tristate '  Au1000 Sound' CONFIG_SOUND_AU1000 $CONFIG_SOUND
 fi
 
-dep_tristate '  Trident 4DWave DX/NX, SiS 7018 or ALi 5451 PCI Audio Core' CONFIG_SOUND_TRIDENT $CONFIG_SOUND $CONFIG_PCI $CONFIG_INPUT_PCIGAME
+# This is fairly ugly. If pcigame is off, we have no dependency on it. 
+# However, if it's on and modular, we need to be modular too 
+if [ "$CONFIG_INPUT_PCIGAME" = "n" ]; then 
+    dep_tristate '  Trident 4DWave DX/NX, SiS 7018 or ALi 5451 PCI Audio Core' CONFIG_SOUND_TRIDENT $CONFIG_SOUND $CONFIG_PCI
+else 
+    dep_tristate '  Trident 4DWave DX/NX, SiS 7018 or ALi 5451 PCI Audio Core' CONFIG_SOUND_TRIDENT $CONFIG_SOUND $CONFIG_PCI $CONFIG_INPUT_PCIGAME
+fi 
+
 
 dep_tristate '  Support for Turtle Beach MultiSound Classic, Tahiti, Monterey' CONFIG_SOUND_MSNDCLAS $CONFIG_SOUND
 if [ "$CONFIG_SOUND_MSNDCLAS" = "y" -o "$CONFIG_SOUND_MSNDCLAS" = "m" ]; then
-- 
Muli Ben-Yehuda
http://www.mulix.org


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]