From: Andi Kleen <ak@muc.de>
To: Andrew Morton <akpm@digeo.com>
Cc: Andi Kleen <ak@muc.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use correct page protection for put_dirty_page
Date: Sun, 11 May 2003 10:37:08 +0200 [thread overview]
Message-ID: <20030511083708.GB31932@averell> (raw)
In-Reply-To: <20030511013226.25e690bf.akpm@digeo.com>
On Sun, May 11, 2003 at 10:32:26AM +0200, Andrew Morton wrote:
> Andi Kleen <ak@muc.de> wrote:
> >
> > put_page_dirty must use the page protection of the stack VMA, not hardcoded
> > PAGE_COPY. They can be different e.g. when the stack is set non executable
> > via VM_STACK_FLAGS.
>
> OK. It seems a bit inefficient to go looking up the vma immediately after
> having created it.
>
> How about we simply pass the desired protection in to put_dirty_page()?
Fine by me.
-Andi
prev parent reply other threads:[~2003-05-11 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-11 8:08 [PATCH] Use correct page protection for put_dirty_page Andi Kleen
2003-05-11 8:30 ` William Lee Irwin III
2003-05-11 8:36 ` Andi Kleen
2003-05-11 8:32 ` Andrew Morton
2003-05-11 8:37 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030511083708.GB31932@averell \
--to=ak@muc.de \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox