public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Dave Jones <davej@codemonkey.org.uk>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [patch] 2.5.69-dj1: agp_init shouldn't be static
Date: Sun, 11 May 2003 14:29:35 +0200	[thread overview]
Message-ID: <20030511122934.GH1107@fs.tum.de> (raw)
In-Reply-To: <20030510145653.GA26216@suse.de>


-dj makes agp_init static resulting in the following error at the final 
linking:


<--  snip  -->

...
386/oprofile/built-in.o  net/built-in.o --end-group  -o .tmp_vmlinux1
drivers/built-in.o(.init.text+0x6b584): In function `i810fb_init':
: undefined reference to `agp_init'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


The following patch fixes it:


--- linux-2.5.69-dj1/drivers/char/agp/backend.c.old	2003-05-11 14:12:29.000000000 +0200
+++ linux-2.5.69-dj1/drivers/char/agp/backend.c	2003-05-11 14:13:30.000000000 +0200
@@ -307,7 +307,7 @@
 EXPORT_SYMBOL_GPL(agp_remove_bridge);
 
 
-static int __init agp_init(void)
+int __init agp_init(void)
 {
 	printk(KERN_INFO "Linux agpgart interface v%d.%d (c) Dave Jones\n",
 	       AGPGART_VERSION_MAJOR, AGPGART_VERSION_MINOR);



cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2003-05-11 12:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-10 14:56 Linux 2.5.69-dj1 Dave Jones
2003-05-11  8:54 ` [patch] 2.5.69-dj1: tlan.c doesn't compile Adrian Bunk
2003-05-11  9:46 ` 2.5.69-dj1: bogus sound/isa/dt019x.c changes Adrian Bunk
2003-05-11 12:29 ` Adrian Bunk [this message]
2003-05-11 13:21   ` [patch] 2.5.69-dj1: agp_init shouldn't be static Dave Jones
2003-05-11 13:51     ` Christoph Hellwig
2003-05-11 22:09       ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030511122934.GH1107@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox