public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Christoph Hellwig <hch@infradead.org>,
	Adrian Bunk <bunk@fs.tum.de>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] 2.5.69-dj1: agp_init shouldn't be static
Date: Sun, 11 May 2003 23:09:57 +0100	[thread overview]
Message-ID: <20030511220957.GA20415@suse.de> (raw)
In-Reply-To: <20030511145148.A20017@infradead.org>

On Sun, May 11, 2003 at 02:51:48PM +0100, Christoph Hellwig wrote:
 > On Sun, May 11, 2003 at 02:21:20PM +0100, Dave Jones wrote:
 > > duhh, the 810 framebuffer needs it early. I forgot about that.
 > > Will apply patch, and add a comment. Thanks.
 > 
 > no, it doesn't need the agp banner printk early :)  Fix i810fb instead.

Ahh crap, this may bring up another problem. The agpgart _has_ to be
initialised before the i810fb code, otherwise it won't work.
Now that agp_init() doesn't do anything useful, we're relying
on link order.  Whether we get that right or not right now depends..
Needs to be tested by someone who actually uses i810fb to be sure.

Volunteers?  (Just chop out the agp_init call in
drivers/video/i810/i810_main.c), oh and I'm only interested in
feedback from either users of 2.5.69-dj1, or 2.5 bitkeeper tree,
(Linus seems to have taken the first round of AGP updates in the last few hours).

		Dave


      reply	other threads:[~2003-05-11 22:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-10 14:56 Linux 2.5.69-dj1 Dave Jones
2003-05-11  8:54 ` [patch] 2.5.69-dj1: tlan.c doesn't compile Adrian Bunk
2003-05-11  9:46 ` 2.5.69-dj1: bogus sound/isa/dt019x.c changes Adrian Bunk
2003-05-11 12:29 ` [patch] 2.5.69-dj1: agp_init shouldn't be static Adrian Bunk
2003-05-11 13:21   ` Dave Jones
2003-05-11 13:51     ` Christoph Hellwig
2003-05-11 22:09       ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030511220957.GA20415@suse.de \
    --to=davej@codemonkey.org.uk \
    --cc=bunk@fs.tum.de \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox