Re: [linux-usb-devel] Patch for usb-ohci in 2.4 needs review & testing

[Pete Zaitcev <zaitcev@redhat.com>]

> From: David Brownell <david-b@pacbell.net>
> Date: Mon, 12 May 2003 09:19:48 -0700

> > The attached patch appears to fix a bug which was really making
> > my life difficult: dd if=/dev/scd0 produces corrupted ISOs when
> > reading off a USB CD-ROM on a box with no less than 2 P4 CPUs,
> > HyperThreading and ServerWorks chipset. However, I'm not
> > completely sure that I didn't break something.
> 
> Did the "ohci-hcd" backport give the same problem?
> Or did you not try that?

> That 2.5 code has had a lot more attention paid to it
> with respect to locking and similar less-common problems.
> Personally I'd rather see that version get the attention,
> so both 2.4 and 2.5 get the benefits, although I can also
> understand wanting changes that seem more incremental.

Greg sent me that, but I haven't tried it yet. Sorry.

Obviously, ohci-hcd is better, but you know where I work.
We have to support ancient codebases practically forever,
despite what press says. The ohci fix we talk about comes
from qualifying 2.4.9 on top of the line hardware, some of
which is not released yet.

> >  - The whole idea of checking jiffy-sized timeouts from an interrupt
> >    is revolting, but I am wary of unknown here, so I didn't kill it.
> >    If anyone knows how that abomination came to life, I'll be glad
> >    to know too.
> 
> It shouldn't actually be alive ... never enabled,
> because never debugged (and submitted by accident).
> Safe IMO to remove completely.

Heh. I'm afraid I won't be able to touch it, see above.

I'll look on the ohci-hcd, but certain events may be pushing
it to next week.

-- Pete