Re: [PATCH] better ali1563 integrated ethernet support

Re: [PATCH] better ali1563 integrated ethernet support

[Dave Jones]

On Sun, May 11, 2003 at 06:24:44PM +0000, Linux Kernel wrote:
 > ChangeSet 1.1111, 2003/05/11 14:24:44-04:00, dean@arctic.org
 > 
 > 	[PATCH] better ali1563 integrated ethernet support
 > 	
 > 	it turns out the tulip driver is a much better driver for the integrated
 > 	ali1563 ethernet than the dmfe driver... the dmfe driver gets tx timeouts
 > 	every ~15s and can't receive over 5MB/s.  but with the small tulip patch
 > 	below i'm seeing 11MB/s+ in both directions without problems.
 > 
 > diff -Nru a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
 > --- a/drivers/net/tulip/tulip_core.c	Sun May 11 12:14:32 2003
 > +++ b/drivers/net/tulip/tulip_core.c	Sun May 11 12:14:32 2003
 > @@ -223,6 +223,7 @@
 >  	{ 0x1626, 0x8410, PCI_ANY_ID, PCI_ANY_ID, 0, 0, COMET },
 >  	{ 0x1737, 0xAB09, PCI_ANY_ID, PCI_ANY_ID, 0, 0, COMET },
 >  	{ 0x17B3, 0xAB08, PCI_ANY_ID, PCI_ANY_ID, 0, 0, COMET },
 > + 	{ 0x10b9, 0x5261, PCI_ANY_ID, PCI_ANY_ID, 0, 0, DM910X },	/* ALi 1563 integrated ethernet */
 >  	{ } /* terminate list */
 >  };
 >  MODULE_DEVICE_TABLE(pci, tulip_pci_tbl);

 ...
  
 >  #if defined(__sparc__)
 >          /* DM9102A needs 32-dword alignment/burst length on sparc - chip bug? */
 > -        if (pdev->vendor == 0x1282 && pdev->device == 0x9102)
 > +	if ((pdev->vendor == 0x1282 && pdev->device == 0x9102)
 > +		|| (pdev->vendor == 0x10b9 && pdev->device == 0x5261))
 >                  csr0 = (csr0 & ~0xff00) | 0xe000;
 >  #endif

Integrated ALi 1563 on a sparc ?

		Dave

Re: [PATCH] better ali1563 integrated ethernet support

[dean gaudet]

On Mon, 12 May 2003, Dave Jones wrote:

>  >  #if defined(__sparc__)
>  >          /* DM9102A needs 32-dword alignment/burst length on sparc - chip bug? */
>  > -        if (pdev->vendor == 0x1282 && pdev->device == 0x9102)
>  > +	if ((pdev->vendor == 0x1282 && pdev->device == 0x9102)
>  > +		|| (pdev->vendor == 0x10b9 && pdev->device == 0x5261))
>  >                  csr0 = (csr0 & ~0xff00) | 0xe000;
>  >  #endif
>
> Integrated ALi 1563 on a sparc ?

oh duh i didn't even look hard at that... i just went and made sure any
9102 bug tests were copied, in case the ali1563 was a bug-for-bug clone :)
1563 is a hypertransport device... so i doubt it'll show up on a sparc.
oops.

-dean

Re: [PATCH] better ali1563 integrated ethernet support

[Dave Jones]

On Mon, May 12, 2003 at 10:31:44AM -0700, dean gaudet wrote:
 > >  >  #if defined(__sparc__)
 > >  >          /* DM9102A needs 32-dword alignment/burst length on sparc - chip bug? */
 > >  > -        if (pdev->vendor == 0x1282 && pdev->device == 0x9102)
 > >  > +	if ((pdev->vendor == 0x1282 && pdev->device == 0x9102)
 > >  > +		|| (pdev->vendor == 0x10b9 && pdev->device == 0x5261))
 > >  >                  csr0 = (csr0 & ~0xff00) | 0xe000;
 > >  >  #endif
 > >
 > > Integrated ALi 1563 on a sparc ?
 > 
 > oh duh i didn't even look hard at that... i just went and made sure any
 > 9102 bug tests were copied, in case the ali1563 was a bug-for-bug clone :)
 > 1563 is a hypertransport device... so i doubt it'll show up on a sparc.
 > oops.

For completeness, we should probably remove the entry from the dmfe
pci_device_id table too.

		Dave