From: Alex Riesen <fork0@users.sf.net>
To: Paul Fulghum <paulkf@microgate.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Russell King <rmk@arm.linux.org.uk>,
Felipe Alfaro Solana <felipe_alfaro@linuxmail.org>,
David Hinds <dahinds@users.sourceforge.net>
Subject: Re: 2.5.69+bk: "sleeping function called from illegal context" on card release while shutting down
Date: Tue, 13 May 2003 20:46:49 +0200 [thread overview]
Message-ID: <20030513184649.GA1366@steel> (raw)
Thanks Paul,
your last suggestion (pcnet_close) helped. The previous patch was not
enough, of course.
I tried hard to reproduce it, and almost broke the card.
No "wrong sleepers" seen anymore.
Someone still has to remove the timer. It is not used anymore, in this
file, at least.
-alex
--- a/drivers/net/pcmcia/pcnet_cs.c 2003-05-13 20:34:12.000000000 +0200
+++ b/drivers/net/pcmcia/pcnet_cs.c 2003-05-13 20:34:08.000000000 +0200
@@ -848,7 +848,7 @@ static int pcnet_event(event_t event, in
link->state &= ~DEV_PRESENT;
if (link->state & DEV_CONFIG) {
netif_device_detach(&info->dev);
- mod_timer(&link->release, jiffies + HZ/20);
+ pcnet_release(link);
}
break;
case CS_EVENT_CARD_INSERTION:
@@ -1054,7 +1054,7 @@ static int pcnet_close(struct net_device
netif_stop_queue(dev);
del_timer(&info->watchdog);
if (link->state & DEV_STALE_CONFIG)
- mod_timer(&link->release, jiffies + HZ/20);
+ pcnet_release((u_long)link);
return 0;
} /* pcnet_close */
next reply other threads:[~2003-05-13 18:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-13 18:46 Alex Riesen [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-05-13 13:57 2.5.69+bk: "sleeping function called from illegal context" on card release while shutting down Alex Riesen
2003-05-13 14:58 ` Felipe Alfaro Solana
2003-05-13 15:31 ` Paul Fulghum
2003-05-13 16:08 ` Russell King
2003-05-13 17:21 ` Alex Riesen
2003-05-13 17:28 ` Paul Fulghum
2003-05-13 17:33 ` Alex Riesen
2003-05-13 21:52 ` Felipe Alfaro Solana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030513184649.GA1366@steel \
--to=fork0@users.sf.net \
--cc=dahinds@users.sourceforge.net \
--cc=felipe_alfaro@linuxmail.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox