From: Russell King <rmk@arm.linux.org.uk>
To: William Lee Irwin III <wli@holomorphy.com>,
mjacob@quaver.net, linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.4 fix to allow vmalloc at interrupt time
Date: Tue, 13 May 2003 23:40:50 +0100 [thread overview]
Message-ID: <20030513234050.G15172@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20030513211707.GU8978@holomorphy.com>; from wli@holomorphy.com on Tue, May 13, 2003 at 02:17:07PM -0700
On Tue, May 13, 2003 at 02:17:07PM -0700, William Lee Irwin III wrote:
> On Tue, May 13, 2003 at 02:11:12PM -0700, Matthew Jacob wrote:
> > This fixes a buglet wrt doing vmalloc at interrupt time for 2.4.
> > get_vm_area should call kmalloc with GFP_ATOMIC- after all, it's
> > set up to allow for an allocation failure. As best as I read
> > the 2.4 code, the rest of the path through _kmem_cache_alloc
> > should be safe.
>
> Try write_lock_irq(&vmlist_lock)/read_lock_irq(&vmlist_lock) and
> passing in a gfp mask with an alternative API etc. for the interrupt
> time special case. It's deadlockable without at least the locking bits.
>
> But it's worse than that, the implicit smp_call_function() means this
> is stillborn and infeasible period.
Not to mention the page table allocation code...
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2003-05-13 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-12 22:56 [patch] 2.4 ac97_codec micboost control Shane Wegner
2003-05-13 21:11 ` [patch] 2.4 fix to allow vmalloc at interrupt time Matthew Jacob
2003-05-13 21:17 ` William Lee Irwin III
2003-05-13 21:28 ` Matthew Jacob
2003-05-13 22:40 ` Russell King [this message]
2003-05-13 21:18 ` Christoph Hellwig
2003-05-13 22:34 ` Alan Cox
2003-05-13 23:21 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030513234050.G15172@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mjacob@quaver.net \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox