Re: ahc_linux_map_seg() compile/style/data corruption fixes

Justin T. Gibbs
2003-05-14T06:14:06Z

>>> For the connoisseur, I've attached before/after disassemblies
>>> demonstrating that the if () whose failure is caused by (2) is a very,
>>> very, very real problem.
>
> On Wed, May 14, 2003 at 12:18:57AM -0600, Justin T. Gibbs wrote:
>> This was obvious from code inspection.
>
> ISTR a debate where it was claimed the constant would be implicitly
> promoted.

Promotion to long is all that is guaranteed at least up to C89. I
don't think that C99 has changed this. The use of ULL in the code
is required.

--
Justin