From: Andrea Arcangeli <andrea@suse.de>
To: Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2003@gmx.net>
Cc: linux-kernel@vger.kernel.org, Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Re: 2.4.21rc2aa1
Date: Thu, 15 May 2003 01:18:38 +0200 [thread overview]
Message-ID: <20030514231838.GP1429@dualathlon.random> (raw)
In-Reply-To: <3EC2C5AC.6050709@gmx.net>
On Thu, May 15, 2003 at 12:39:40AM +0200, Carl-Daniel Hailfinger wrote:
> Andrea Arcangeli wrote:
>
> > Only in 2.4.21rc2aa1: 00_remove_inode_page-prune_icache-smp-race-1
> >
> > Fix mm corrupting SMP race between remove_inode_page and prune_icache.
> > Found by Chris Mason.
>
> Any chance this will get into mainline before 2.4.21?
it's obviously safe so I think yes:
--- x/mm/filemap.c.~1~ 2003-04-24 16:37:50.000000000 +0200
+++ x/mm/filemap.c 2003-04-24 17:05:10.000000000 +0200
@@ -100,9 +100,10 @@ static inline void remove_page_from_inod
if (mapping->a_ops->removepage)
mapping->a_ops->removepage(page);
- mapping->nrpages--;
list_del(&page->list);
page->mapping = NULL;
+ wmb();
+ mapping->nrpages--;
}
static inline void remove_page_from_hash_queue(struct page * page)
Marcelo please apply, thanks!
Andrea
prev parent reply other threads:[~2003-05-14 23:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-14 20:22 2.4.21rc2aa1 Andrea Arcangeli
2003-05-14 22:39 ` 2.4.21rc2aa1 Carl-Daniel Hailfinger
2003-05-14 23:18 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030514231838.GP1429@dualathlon.random \
--to=andrea@suse.de \
--cc=c-d.hailfinger.kernel.2003@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox