Re: 2.5.69-mm5: pccard oops while booting: resolved

Felipe Alfaro Solana
2003-05-15T11:24:21Z

On Thu, 2003-05-15 at 04:17, Andrew Morton wrote:
> Felipe Alfaro Solana <felipe_alfaro@linuxmail.org> wrote:
> >
> > I've been able to pinpoint the culprit of this: it's the
> > "make-KOBJ_NAME-match-BUS_ID_SIZE.patch" patch that it's causing the
> > oops for me when booting 2.5.69.mm5.
> >
> > Reverting this patch solves the oops for me.
>
> I might have screwed that patch up.
>
> This is the second half of it. When it crashed, did you have the below
> change in place as well?
>
> Index: include/linux/device.h
> ===================================================================
> RCS file: /home/scm/linux-2.5/include/linux/device.h,v
> retrieving revision 1.48
> diff -u -u -r1.48 device.h
> --- include/linux/device.h 29 Apr 2003 17:30:20 -0000 1.48
> +++ include/linux/device.h 13 May 2003 07:47:39 -0000
> @@ -35,7 +35,7 @@
> #define DEVICE_NAME_SIZE 50
> #define DEVICE_NAME_HALF __stringify(20) /* Less than half to accommodate slop */
> #define DEVICE_ID_SIZE 32
> -#define BUS_ID_SIZE 20
> +#define BUS_ID_SIZE KOBJ_NAME_LEN
>
>
> enum {
> -

I applied the second half patch on top of 2.5.69-mm5 (the original
2.5.69-mm5 defined BUS_ID_SIZE as 20), but the "pccard" kernel task
keeps crashing as before.

Anything else for me to try? :-)

Thanks!