From: Andrey Panin <pazke@donpac.ru>
To: Jes Sorensen <jes@wildopensource.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: qla1280 mem-mapped I/O fix
Date: Fri, 16 May 2003 08:06:30 +0400 [thread overview]
Message-ID: <20030516040630.GA20160@pazke> (raw)
In-Reply-To: <m3addoqkaa.fsf@trained-monkey.org>
On 135, 05 15, 2003 at 11:52:45AM -0400, Jes Sorensen wrote:
> >>>>> "Arjan" == Arjan van de Ven <arjanv@redhat.com> writes:
>
> >> @@ -2634,7 +2634,7 @@ /* * Get memory mapped I/O address. */ -
> >> pci_read_config_word (ha->pdev, PCI_BASE_ADDRESS_1, &mmapbase); +
> >> pci_read_config_dword (ha->pdev, PCI_BASE_ADDRESS_1, &mmapbase);
> >> mmapbase &= PCI_BASE_ADDRESS_MEM_MASK;
> >>
> >>
> Arjan> shouldn't this be pci_resource_start() ?
>
> Yep,
>
> The existing code is a nightmare, I am working on cleaning this up so
> we can get rid of all the I/O ports crap.
Do you want to convert this driver to use memmaped io only ?
That's bad news for me and visws subarch.
--
Andrey Panin | Embedded systems software developer
pazke@orbita1.ru | PGP key: wwwkeys.pgp.net
next prev parent reply other threads:[~2003-05-16 3:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-10 9:51 qla1280 mem-mapped I/O fix David Mosberger
2003-05-10 10:15 ` Arjan van de Ven
2003-05-10 10:25 ` David Mosberger
2003-05-15 15:52 ` Jes Sorensen
2003-05-16 4:06 ` Andrey Panin [this message]
2003-05-10 11:30 ` David S. Miller
2003-05-10 11:34 ` David Mosberger
2003-05-10 12:12 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030516040630.GA20160@pazke \
--to=pazke@donpac.ru \
--cc=jes@wildopensource.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox