* Incorrect AMD74xx UDMA100 test.
@ 2003-05-15 3:31 davej
2003-05-16 14:17 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: davej @ 2003-05-15 3:31 UTC (permalink / raw)
To: alan; +Cc: linux-kernel
We do 80wire comparisons based on an uninitialised var.
Shouldn't we also be doing the 80wire check on the UDMA66 case ?
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/ide/pci/amd74xx.c linux-2.5/drivers/ide/pci/amd74xx.c
--- bk-linus/drivers/ide/pci/amd74xx.c 2003-04-10 06:01:18.000000000 +0100
+++ linux-2.5/drivers/ide/pci/amd74xx.c 2003-03-22 12:41:47.000000000 +0000
@@ -313,7 +313,8 @@ static unsigned int __init init_chipset_
case AMD_UDMA_100:
pci_read_config_byte(dev, AMD_CABLE_DETECT, &t);
- amd_80w = ((u & 0x3) ? 1 : 0) | ((u & 0xc) ? 2 : 0);
+ amd_80w = ((t & 0x3) ? 1 : 0) | ((t & 0xc) ? 2 : 0);
+ pci_read_config_dword(dev, AMD_UDMA_TIMING, &u);
for (i = 24; i >= 0; i -= 8)
if (((u >> i) & 4) && !(amd_80w & (1 << (1 - (i >> 4))))) {
printk(KERN_WARNING "AMD_IDE: Bios didn't set cable bits correctly. Enabling workaround.\n");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Incorrect AMD74xx UDMA100 test.
2003-05-15 3:31 Incorrect AMD74xx UDMA100 test davej
@ 2003-05-16 14:17 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2003-05-16 14:17 UTC (permalink / raw)
To: davej; +Cc: alan, linux-kernel
> We do 80wire comparisons based on an uninitialised var.
> Shouldn't we also be doing the 80wire check on the UDMA66 case ?
Yeah I thought that was fixed in 2.5.x and 2.4.x already
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-05-16 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-15 3:31 Incorrect AMD74xx UDMA100 test davej
2003-05-16 14:17 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox