From: Duncan Sands <baldrick@wanadoo.fr>
To: chas williams <chas@locutus.cmf.nrl.navy.mil>,
Greg KH <greg@kroah.com>,
davem@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ATM] add reference counting to atm_dev
Date: Fri, 16 May 2003 16:40:43 +0200 [thread overview]
Message-ID: <200305161640.43804.baldrick@wanadoo.fr> (raw)
In-Reply-To: <200305151432.h4FEW5Gi012599@locutus.cmf.nrl.navy.mil>
On Thursday 15 May 2003 16:32, chas williams wrote:
> In message <20030515052041.GA5995@kroah.com>,Greg KH writes:
> >It's not really bothering me, just wondering when it will go away (I see
> >it when building one of the USB ATM drivers...)
>
> the MOD_* functions in the speedtch driver don't need to be there.
> since 2.3.something (if i remember correctly) the reference counting
> has been handled by the upper layer (ala fops_get/fops_put). the
> following patch removes these extra bits:
Hi Chas, thanks for the patch. I agree that it is correct. However,
I was wondering about ioctl and proc calls. Can the ATM layer call
a driver's ioctl routine before opening a vcc? If so, does it take a
reference to the module first (I didn't spot anything)? Also, are
calls to a driver's proc_read routine protected against module
unloading races (I confess I didn't take the time to look into this,
because my own driver does not sleep in proc_read)?
All the best,
Duncan.
next prev parent reply other threads:[~2003-05-16 14:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-14 20:20 [PATCH][ATM] add reference counting to atm_dev chas williams
2003-05-14 20:36 ` David S. Miller
2003-05-14 22:16 ` chas williams
2003-05-15 4:30 ` David S. Miller
2003-05-15 14:39 ` chas williams
2003-05-15 20:10 ` David S. Miller
2003-05-15 20:20 ` chas williams
2003-05-16 0:14 ` David S. Miller
2003-05-16 16:05 ` chas williams
2003-05-16 20:44 ` David S. Miller
2003-05-16 0:19 ` David S. Miller
2003-05-14 20:59 ` Greg KH
2003-05-14 21:02 ` David S. Miller
2003-05-14 21:57 ` Greg KH
2003-05-14 22:21 ` chas williams
2003-05-15 5:20 ` Greg KH
2003-05-15 14:32 ` chas williams
2003-05-15 19:09 ` Greg KH
2003-05-15 19:17 ` chas williams
2003-05-20 12:25 ` Duncan Sands
2003-05-16 0:12 ` David S. Miller
2003-05-16 14:40 ` Duncan Sands [this message]
2003-05-16 15:39 ` chas williams
2003-05-16 18:48 ` Francois Romieu
2003-05-22 17:59 ` Linux 2.4 scheduler is RTOS-alike? Ming Lei
2003-05-22 20:01 ` Ming Lei
2003-05-22 20:37 ` Elladan
2003-05-22 20:47 ` Elladan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305161640.43804.baldrick@wanadoo.fr \
--to=baldrick@wanadoo.fr \
--cc=chas@locutus.cmf.nrl.navy.mil \
--cc=davem@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox