From: David Gibson <david@gibson.dropbear.id.au>
To: Linus Torvalds <torvalds@transmeta.com>, Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org, Anton Blanchard <anton@samba.org>
Subject: [PATCH] rename and extend check_valid_hugepage_range()
Date: Mon, 19 May 2003 16:15:25 +1000 [thread overview]
Message-ID: <20030519061525.GA4140@zax> (raw)
Linus, please apply:
check_valid_hugepage_range() is a terrible name, because what it's
actually used to check is whether a range is invalid for normal pages,
rather than whether it's valid for hugepages. It returns 0
(i.e. normal pages are ok) uniformly on all existing hugepage
implementations. The patch below renames it to
"is_hugepage_only_range()".
Due to segment insanity, we'll need to override this function for the
ppc64 implementation of hugetlbfs which I'm working on. However,
we'll need access to the mm_struct to do it. This patch also adds
that.
diff -urN linux-congo/include/linux/hugetlb.h linux-hugepage/include/linux/hugetlb.h
--- linux-congo/include/linux/hugetlb.h 2003-03-10 08:16:21.000000000 +1100
+++ linux-hugepage/include/linux/hugetlb.h 2003-05-19 16:02:13.000000000 +1000
@@ -37,8 +37,8 @@
mm->used_hugetlb = 1;
}
-#ifndef ARCH_HAS_VALID_HUGEPAGE_RANGE
-#define check_valid_hugepage_range(addr, len) 0
+#ifndef ARCH_HAS_HUGEPAGE_ONLY_RANGE
+#define is_hugepage_only_range(mm, addr, len) 0
#endif
#else /* !CONFIG_HUGETLB_PAGE */
@@ -62,7 +62,7 @@
#define follow_huge_pmd(mm, addr, pmd, write) 0
#define is_aligned_hugepage_range(addr, len) 0
#define pmd_huge(x) 0
-#define check_valid_hugepage_range(addr, len) 0
+#define is_hugepage_only_range(mm, addr, len) 0
#ifndef HPAGE_MASK
#define HPAGE_MASK 0 /* Keep the compiler happy */
diff -urN linux-congo/mm/mmap.c linux-hugepage/mm/mmap.c
--- linux-congo/mm/mmap.c 2003-04-24 18:54:37.000000000 +1000
+++ linux-hugepage/mm/mmap.c 2003-05-19 16:02:21.000000000 +1000
@@ -829,7 +829,7 @@
* reserved hugepage range. For some archs like IA-64,
* there is a separate region for hugepages.
*/
- ret = check_valid_hugepage_range(addr, len);
+ ret = is_hugepage_only_range(mm, addr, len);
}
if (ret)
return ret;
--
David Gibson | For every complex problem there is a
david@gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
next reply other threads:[~2003-05-19 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-19 6:15 David Gibson [this message]
2003-05-22 1:54 ` [PATCH] rename and extend check_valid_hugepage_range() David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030519061525.GA4140@zax \
--to=david@gibson.dropbear.id.au \
--cc=akpm@digeo.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox