From: Rusty Russell <rusty@rustcorp.com.au>
To: Ingo Oeser <ingo.oeser@informatik.tu-chemnitz.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: try_then_request_module
Date: Tue, 20 May 2003 10:19:00 +1000 [thread overview]
Message-ID: <20030520003322.D38CA2C09D@lists.samba.org> (raw)
In-Reply-To: Your message of "Mon, 19 May 2003 11:08:32 +0200." <20030519110832.G626@nightmaster.csn.tu-chemnitz.de>
In message <20030519110832.G626@nightmaster.csn.tu-chemnitz.de> you write:
> So try_then_request_module() will consolidate the the
> branch or in the worst case just duplicating that code
> everywhere (depends on wether you implement it as a non-inline
> function or define).
I'm not speculating: here it is from kmod.h:
#define try_then_request_module(x, mod...) ((x) ?: request_module(mod), (x))
It really should be:
#ifdef CONFIG_KMOD
#define try_then_request_module(x, mod...) ((x) ?: request_module(mod), (x))
#else
#define try_then_request_module(x, mod...) (x)
#endif /* CONFIG_KMOD */
Patches welcome.
Getting rid of the CONFIG_KMOD's in general code without leaving
unused code around is the aim here.
Hope that clarifies!
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
prev parent reply other threads:[~2003-05-20 0:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-19 1:41 try_then_request_module Rusty Russell
2003-05-19 9:08 ` try_then_request_module Ingo Oeser
2003-05-19 18:50 ` try_then_request_module Riley Williams
2003-05-20 7:39 ` try_then_request_module Ingo Oeser
2003-05-21 23:18 ` try_then_request_module Riley Williams
2003-05-20 0:19 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030520003322.D38CA2C09D@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=ingo.oeser@informatik.tu-chemnitz.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox