From: David Gibson <david@gibson.dropbear.id.au>
To: Greg KH <greg@kroah.com>
Cc: Manuel Estrada Sainz <ranty@debian.org>,
LKML <linux-kernel@vger.kernel.org>,
Simon Kelley <simon@thekelleys.org.uk>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
jt@hpl.hp.com, Pavel Roskin <proski@gnu.org>,
Oliver Neukum <oliver@neukum.org>
Subject: Re: request_firmware() hotplug interface, third round and a halve
Date: Wed, 21 May 2003 17:44:56 +1000 [thread overview]
Message-ID: <20030521074456.GH23736@zax> (raw)
In-Reply-To: <20030521072318.GA12973@kroah.com>
On Wed, May 21, 2003 at 12:23:18AM -0700, Greg Kroah-Hartman wrote:
> > +struct firmware_priv {
> > + char fw_id[FIRMWARE_NAME_MAX];
> > + struct completion completion;
> > + struct bin_attribute attr_data;
> > + struct firmware *fw;
> > + s32 loading:2;
> > + u32 abort:1;
>
> Why s32 and u32? Why not just ints for both of them?
And for that matter, I don't think there's any point using bitfields,
61 bits is not worth it.
--
David Gibson | For every complex problem there is a
david@gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
next prev parent reply other threads:[~2003-05-21 7:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-17 22:19 request_firmware() hotplug interface, third round and a halve Manuel Estrada Sainz
2003-05-21 7:23 ` Greg KH
2003-05-21 7:44 ` David Gibson [this message]
2003-05-21 18:36 ` Manuel Estrada Sainz
2003-05-21 18:34 ` Manuel Estrada Sainz
2003-05-21 19:03 ` Greg KH
2003-05-21 18:52 ` [PATCH] " Manuel Estrada Sainz
2003-05-21 20:07 ` Greg KH
2003-05-22 15:31 ` Manuel Estrada Sainz
2003-05-22 16:14 ` Patrick Mochel
2003-05-22 16:34 ` Manuel Estrada Sainz
2003-05-22 16:38 ` Patrick Mochel
2003-05-22 16:43 ` Manuel Estrada Sainz
2003-05-22 16:51 ` Patrick Mochel
2003-05-22 17:01 ` Manuel Estrada Sainz
2003-05-22 17:03 ` Patrick Mochel
2003-05-22 17:57 ` Simon Kelley
2003-05-22 18:15 ` Manuel Estrada Sainz
2003-05-21 21:51 ` Sam Ravnborg
2003-05-22 6:26 ` Manuel Estrada Sainz
-- strict thread matches above, loose matches on Subject: below --
2003-05-18 16:14 Alexey Mahotkin
2003-05-18 18:17 ` Manuel Estrada Sainz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030521074456.GH23736@zax \
--to=david@gibson.dropbear.id.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=proski@gnu.org \
--cc=ranty@debian.org \
--cc=simon@thekelleys.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox