From: Jens Axboe <axboe@suse.de>
To: Andy Polyakov <appro@fy.chalmers.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.69-70 ide-cd to guarantee fault-free CD/DVD burning experience?
Date: Wed, 28 May 2003 09:52:39 +0200 [thread overview]
Message-ID: <20030528075239.GW845@suse.de> (raw)
In-Reply-To: <20030528074839.GU845@suse.de>
On Wed, May 28 2003, Jens Axboe wrote:
> > @@ -1609,7 +1615,7 @@
> >
> > static void post_transform_command(struct request *req)
> > {
> > - char *ibuf = req->buffer;
> > + char *ibuf = req->data?req->data:req->buffer;
> > u8 *c = req->cmd;
> >
> > if (!blk_pc_request(req))
>
> That is bad, though. I've changed this to just bail on !ibuf.
Sorry I misread that, ->data is the one we want. I'm wondering how this
got mixed up... So to clarify:
char *ibuf = req->data;
if (!blk_pc_request(req))
return;
if (!ibuf)
return;
--
Jens Axboe
next prev parent reply other threads:[~2003-05-28 7:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-28 7:41 2.5.69-70 ide-cd to guarantee fault-free CD/DVD burning experience? Andy Polyakov
2003-05-28 7:48 ` Jens Axboe
2003-05-28 7:52 ` Jens Axboe [this message]
2003-05-28 16:42 ` Andy Polyakov
2003-05-28 17:03 ` Jens Axboe
2003-05-29 13:50 ` Andy Polyakov
2003-05-29 17:33 ` Jens Axboe
2003-05-28 7:49 ` Jens Axboe
2003-06-04 19:42 ` Andy Polyakov
2003-06-04 19:55 ` Jens Axboe
2003-06-05 21:05 ` Andy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030528075239.GW845@suse.de \
--to=axboe@suse.de \
--cc=appro@fy.chalmers.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox