From: Christoph Hellwig <hch@infradead.org>
To: Michael Hunold <hunold@convergence.de>
Cc: linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: DVB updates, 2nd try
Date: Wed, 28 May 2003 11:12:02 +0100 [thread overview]
Message-ID: <20030528111202.A27811@infradead.org> (raw)
In-Reply-To: <3ED3634A.2000608@convergence.de>; from hunold@convergence.de on Tue, May 27, 2003 at 03:08:26PM +0200
01-av7110-firware.diff
- looks fine (obsiously :)). If the old driver works with the
new firware I'd suggets sending it to Linux now
02-saa7146-core.diff
- the WRITE_RPS0 macro is ugly as hell, you probably want to
replace it with a proper inline. But you can leave this to
a later patch. If it doesn't need the other updates I'd
suggest submitting it now.
03-dvb-core.diff
- okay, this is a big one.. Could you submit the typedef removal
as a first separate patch so the actual changes are reviewable
more easily?
- please use <linux/types.h> not <asm/types.h> everywhere
- please include <asm/*.h> headers after <linux/*.h> ones
- This is wrong:
-static struct dvb_device dvbdev_dvr = {
+static
+struct dvb_device dvbdev_dvr = {
instead of breaking the indention rather fix the reamining parts
of the driver
- dvb_kernel_thread_setup doesn't need the BKL
04-dvb-drivers.diff
- looks ok
05-update-frontends.diff
- looks ok
06-new-frontend.diff
- looks ok (except for the above mentioned indentation issues)
07-dvb-core-lib-user.diff
- looks ok (obviously)
08-analog-saa7146-update.diff
- looks ok (obviously)
09-saa7111-i2c-fix.diff
- looks ok (obviously)
next prev parent reply other threads:[~2003-05-28 9:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-27 13:08 DVB updates, 2nd try Michael Hunold
2003-05-28 10:12 ` Christoph Hellwig [this message]
2003-05-28 12:54 ` Michael Hunold
2003-05-28 12:58 ` Christoph Hellwig
2003-06-18 11:49 ` DVB updates, 3rd try Michael Hunold
2003-06-18 15:58 ` Linus Torvalds
2003-06-18 16:12 ` John Levon
2003-06-19 1:45 ` jw schultz
2003-06-19 2:13 ` John Levon
2003-06-19 8:55 ` jw schultz
2003-06-18 19:39 ` Johannes Stezenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030528111202.A27811@infradead.org \
--to=hch@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hunold@convergence.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox