2.5.70: still no boot logo

2.5.70: still no boot logo

[Bob Tracy]

Yeah, it's minor compared to what *could* be (and probably is) broken.
I've got "CONFIG_LOGO=y" and "CONFIG_LOGO_LINUX_CLUT224=y" with VESA
framebuffer -- the same setup I've used successfully for many moons.

On the positive side, whatever broke in the 2.5.6X series that affected
my DHCP server has been fixed: my HP network printer thanks you :-).
Overall, 2.5.70 seems to be working fine for me other than the minor
matter of the logo at boot time.

-- 
-----------------------------------------------------------------------
Bob Tracy                   WTO + WIPO = DMCA? http://www.anti-dmca.org
rct@frus.com
-----------------------------------------------------------------------

Re: 2.5.70: still no boot logo

[Russell King]

On Wed, May 28, 2003 at 07:51:33AM -0500, Bob Tracy wrote:
> Yeah, it's minor compared to what *could* be (and probably is) broken.
> I've got "CONFIG_LOGO=y" and "CONFIG_LOGO_LINUX_CLUT224=y" with VESA
> framebuffer -- the same setup I've used successfully for many moons.
> 
> On the positive side, whatever broke in the 2.5.6X series that affected
> my DHCP server has been fixed: my HP network printer thanks you :-).
> Overall, 2.5.70 seems to be working fine for me other than the minor
> matter of the logo at boot time.

Someone (I forget who, because I've had the patch so long) sent me this
which fixes the problem for me.

--- orig/drivers/video/cfbimgblt.c	Mon May  5 17:39:49 2003
+++ linux/drivers/video/cfbimgblt.c	Tue May 13 23:53:23 2003
@@ -325,7 +325,7 @@
 		else 
 			slow_imageblit(image, p, dst1, fgcolor, bgcolor,
 					start_index, pitch_index);
-	} else if (image->depth == bpp) 
+	} else if (image->depth <= bpp) 
 		color_imageblit(image, p, dst1, start_index, pitch_index);
 }
 

Can whoever sent this please try to get James to accept the fix and
push it to Linus please?

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html