From: Pete Zaitcev <zaitcev@redhat.com>
To: Richard Braakman <dark@xs4all.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Patch for strncmp use in s390 in 2.5
Date: Wed, 28 May 2003 19:45:20 -0400 [thread overview]
Message-ID: <200305282345.h4SNjKv02989@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.1054159021.10246.linux-kernel2news@redhat.com>
>> I didn't see this posted before. Sorry if I missed it.
>> It's a harmless buglet which causes false positives with correctness
>> checking tools, and so annoys me.
>
> Are you sure it's harmless? Your patch changes the meaning from an
> exact match to a prefix match. I think it's intended to be an exact
> match, but I don't know why it doesn't just use strcmp().
The buglet is harmless. Now, the fix perhaps not.
I think it may be better to replace it with strcmp, too.
-- Pete
prev parent reply other threads:[~2003-05-28 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-28 20:20 Patch for strncmp use in s390 in 2.5 Pete Zaitcev
2003-05-28 20:34 ` Richard B. Johnson
2003-05-28 20:51 ` Patch for strncmp use in s390 (sclp) Pete Zaitcev
2003-05-28 21:55 ` Patch for strncmp use in s390 in 2.5 Richard Braakman
[not found] ` <mailman.1054159021.10246.linux-kernel2news@redhat.com>
2003-05-28 23:45 ` Pete Zaitcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305282345.h4SNjKv02989@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=dark@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox