From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: chas williams <chas@cmf.nrl.navy.mil>
Cc: davem@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ATM] assorted he driver cleanup
Date: Thu, 29 May 2003 14:06:22 -0300 [thread overview]
Message-ID: <20030529170621.GX24054@conectiva.com.br> (raw)
In-Reply-To: <200305291632.h4TGWwsG022510@ginger.cmf.nrl.navy.mil>
Em Thu, May 29, 2003 at 12:31:17PM -0400, chas williams escreveu:
> In message <20030529162125.GU24054@conectiva.com.br>,Arnaldo Carvalho de Melo w
> rites:
> >> @@ -189,7 +187,7 @@
> >> #define HE_SPIN_LOCK(dev, flags) spin_lock_irqsave(&(dev)->global_lock,
> >flags)
> >> #define HE_SPIN_UNLOCK(dev, flags) spin_unlock_irqrestore(&(dev)->global_l
> >ock, flags)
> >
> >Is the above really needed?
>
> well, according to the programmer's guide:
no, no, I was talking just about the need for HE_SPIN_LOCK wrapper, not the
locking, i.e. couldn't it be just:
spin_lock_irqsave(&dev->global_lock, flags)
used so that it is clear that it is a irqsave variation, etc?
- Arnaldo
next prev parent reply other threads:[~2003-05-29 16:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-29 16:09 [PATCH][ATM] assorted he driver cleanup chas williams
2003-05-29 16:19 ` Christoph Hellwig
2003-05-29 16:32 ` chas williams
2003-05-29 16:21 ` Arnaldo Carvalho de Melo
2003-05-29 16:31 ` chas williams
2003-05-29 17:06 ` Arnaldo Carvalho de Melo [this message]
2003-05-29 17:12 ` chas williams
2003-05-29 17:36 ` Arnaldo Carvalho de Melo
2003-06-01 18:57 ` chas williams
2003-06-01 20:00 ` Alan Cox
2003-06-01 22:58 ` chas williams
2003-06-02 1:42 ` David S. Miller
2003-06-02 1:47 ` Arnaldo Carvalho de Melo
2003-06-02 2:34 ` chas williams
2003-06-02 13:50 ` Alan Cox
2003-06-02 1:32 ` David S. Miller
2003-05-29 18:08 ` chas williams
2003-05-29 18:34 ` Arnaldo Carvalho de Melo
2003-05-30 3:01 ` David S. Miller
2003-05-30 8:57 ` Dave Jones
2003-05-30 13:36 ` Jeff Garzik
2003-05-30 13:46 ` chas williams
2003-05-30 14:00 ` chas williams
[not found] ` <200305301431.h4UEVesG003572@ginger.cmf.nrl.navy.mil>
2003-06-04 4:51 ` David S. Miller
2003-06-01 22:42 ` Francois Romieu
2003-06-18 21:08 ` chas williams
2003-06-19 1:05 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030529170621.GX24054@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox