public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: rusty@rustcorp.com.au, hannal@us.ibm.com
Subject: Re: [PATCH] sx tty_driver add .owner field remove MOD_INC_DEC_USE_COUNT
Date: Thu, 29 May 2003 12:02:50 -0700	[thread overview]
Message-ID: <20030529190250.GB24737@kroah.com> (raw)
In-Reply-To: <200305270126.h4R1QjA3029554@hera.kernel.org>

On Tue, May 27, 2003 at 12:01:08AM +0000, Linux Kernel Mailing List wrote:
> ChangeSet 1.1424, 2003/05/26 17:01:08-07:00, rusty@rustcorp.com.au
> 
> 	[PATCH] sx tty_driver add .owner field remove MOD_INC_DEC_USE_COUNT
> 	
> 	From:  Hanna Linder <hannal@us.ibm.com>
> 
> 
> # This patch includes the following deltas:
> #	           ChangeSet	1.1423  -> 1.1424 
> #	   drivers/char/sx.c	1.29    -> 1.30   
> #
> 
>  sx.c |   42 +-----------------------------------------
>  1 files changed, 1 insertion(+), 41 deletions(-)
> 
> 
> diff -Nru a/drivers/char/sx.c b/drivers/char/sx.c
> --- a/drivers/char/sx.c	Mon May 26 18:26:48 2003
> +++ b/drivers/char/sx.c	Mon May 26 18:26:48 2003
> @@ -305,7 +305,6 @@
>  static int  sx_get_CD (void * ptr); 
>  static void sx_shutdown_port (void * ptr);
>  static int  sx_set_real_termios (void  *ptr);
> -static void sx_hungup (void  *ptr);

Ick, this patch should be reverted, it should not be removing
sx_hungup() for no reason.  I think Hanna agrees with this.

thanks,

greg k-h

       reply	other threads:[~2003-05-29 18:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200305270126.h4R1QjA3029554@hera.kernel.org>
2003-05-29 19:02 ` Greg KH [this message]
2003-05-29 21:35   ` [PATCH] sx tty_driver add .owner field remove MOD_INC_DEC_USE_COUNT Hanna Linder
2003-05-30  8:05     ` Rusty Russell
2003-05-30 17:48       ` Hanna Linder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030529190250.GB24737@kroah.com \
    --to=greg@kroah.com \
    --cc=hannal@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox