From: William Lee Irwin III <wli@holomorphy.com>
To: Morten Helgesen <morten.helgesen@nextframe.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: list_head debugging patch
Date: Thu, 29 May 2003 12:38:49 -0700 [thread overview]
Message-ID: <20030529193849.GB8978@holomorphy.com> (raw)
In-Reply-To: <200305292122.44041.morten.helgesen@nextframe.net>
On Thursday 29 May 2003 15:08, William Lee Irwin III wrote:
>> This appears to get the kernel to crap its pants in very, very
>> short order. Given the number of things going wrong, I almost
>> wonder if I did something wrong. Things get real ugly, really,
>> really fast.
On Thu, May 29, 2003 at 09:22:43PM +0200, Morten Helgesen wrote:
> [snip]
> I gave this a go - booted without problems. I did some
> untaring/copying/deleting and didn`t see anything unusual, but a
> 'dbench 8' died right away.
[...]
> EIP is at clear_queue_congested+0x78/0xb0
clear_queue_congested() is doing an opportunistic check for list_empty()
without taking a lock. The patch basically changes list_empty() to look
at elements of the list instead of just pieces of the head. As opposed
to auditing for this, could you remove the __list_head_check() from
list_empty() and try again?
Thanks.
-- wli
next prev parent reply other threads:[~2003-05-29 19:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-29 13:08 list_head debugging patch William Lee Irwin III
2003-05-29 19:22 ` Morten Helgesen
2003-05-29 19:38 ` William Lee Irwin III [this message]
2003-05-29 19:58 ` Morten Helgesen
2003-05-29 20:13 ` William Lee Irwin III
2003-05-29 21:03 ` Morten Helgesen
2003-05-29 21:09 ` William Lee Irwin III
2003-05-29 23:57 ` William Lee Irwin III
2003-05-30 10:54 ` Alan Cox
2003-05-30 12:17 ` Bartlomiej Zolnierkiewicz
2003-05-31 2:22 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030529193849.GB8978@holomorphy.com \
--to=wli@holomorphy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=morten.helgesen@nextframe.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox