public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Andy Polyakov <appro@fy.chalmers.se>
Cc: Markus Plail <linux-kernel@gitteundmarkus.de>,
	linux-kernel@vger.kernel.org
Subject: Re: readcd with 2.5 kernels and ide-cd
Date: Fri, 30 May 2003 08:48:56 +0200	[thread overview]
Message-ID: <20030530064856.GA845@suse.de> (raw)
In-Reply-To: <3ED67F1C.BE1918E4@fy.chalmers.se>

On Thu, May 29 2003, Andy Polyakov wrote:
> > > Is there work going on to get readcd working with 2.5 kernels and
> > > ide-cd (without ide-scsi)?
> > >
> > > strace readcd dev=/dev/dvd f=/dev/null
> > > ...
> > > ioctl(4, SNDCTL_TMR_TIMEBASE, 0xbfffedd8) = -1 ENOTTY (Inappropriate ioctl for device)
> > > ...
> > > ioctl(3, 0x2285, 0xbfffef9c)            = -1 ENOTTY (Inappropriate ioctl for device)
> > 
> > Something _very_ fishy is going on there.
> 
> Nothing fishy, nothing at all... It's as simple as
> driver/block/scsi_ioctl.c doesn't accepts requestes larger than 64KB,
> while readcd asks for 256KB.

Hmm you are right, well we can increase that without any problems. For
bio transfers at least, kmalloc() runs into problems much beyond that.
But for larger transfers, they better be aligned.

> > 0x2285 is the SG_IO ioctl.
> 
> sg_io returns EINVAL (line 163), but driver/block/ioctl.c transforms it
> to ENOTTY (see last 8 lines).

Ah, so that is the bug.

> > First call to it completes, second one returns -ENOTTY. Looks very much
> > like some kernel bug, see the SNDCTL_TMR_TIMEBASE ioctl returning
> > -ENOTTY in-between.
> 
> SNDCTL_TMR_TIMEBASE is actually TCGETS, originates in stdio and is not
> relevant.

Well yes it's resolved incorrectly, the line was the interesting part.
The -ENOTTY was the interesting part, but no not relevant.

-- 
Jens Axboe


  reply	other threads:[~2003-05-30  6:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.hr5v5at.1e5iqab@ifi.uio.no>
     [not found] ` <fa.cqhesj4.p2oeoc@ifi.uio.no>
2003-05-29 21:43   ` readcd with 2.5 kernels and ide-cd Andy Polyakov
2003-05-30  6:48     ` Jens Axboe [this message]
2003-05-30  0:11 Douglas Gilbert
  -- strict thread matches above, loose matches on Subject: below --
2003-05-29 16:44 Markus Plail
2003-05-29 17:30 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030530064856.GA845@suse.de \
    --to=axboe@suse.de \
    --cc=appro@fy.chalmers.se \
    --cc=linux-kernel@gitteundmarkus.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox