From: Dave Jones <davej@codemonkey.org.uk>
To: "David S. Miller" <davem@redhat.com>
Cc: chas@cmf.nrl.navy.mil, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ATM] assorted he driver cleanup
Date: Fri, 30 May 2003 09:57:26 +0100 [thread overview]
Message-ID: <20030530085726.GA14723@suse.de> (raw)
In-Reply-To: <20030529.200101.118622651.davem@redhat.com>
On Thu, May 29, 2003 at 08:01:01PM -0700, David S. Miller wrote:
> BTW, can you use more consistent changeset messages? I always
> at least allude to what is being changed, for example I changed
> all of your messages to be of the form:
>
> [ATM]: Blah blah blah in HE driver.
>
> This tells the reader that:
>
> 1) It's an ATM change.
> 2) It's to the HE driver.
> 3) The change made was "Blah blah blah" :-)
I'd also add...
4) keep the first line a brief oneliner summary, as it
gets truncated when Linus generates the shortlog.
A number of people (self included) have adopted this
impromptu 'standard' for bk comments. Maybe it should
get documented in Documentation/BK-usage/bk-kernel-howto.txt
Dave
next prev parent reply other threads:[~2003-05-30 8:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-29 16:09 [PATCH][ATM] assorted he driver cleanup chas williams
2003-05-29 16:19 ` Christoph Hellwig
2003-05-29 16:32 ` chas williams
2003-05-29 16:21 ` Arnaldo Carvalho de Melo
2003-05-29 16:31 ` chas williams
2003-05-29 17:06 ` Arnaldo Carvalho de Melo
2003-05-29 17:12 ` chas williams
2003-05-29 17:36 ` Arnaldo Carvalho de Melo
2003-06-01 18:57 ` chas williams
2003-06-01 20:00 ` Alan Cox
2003-06-01 22:58 ` chas williams
2003-06-02 1:42 ` David S. Miller
2003-06-02 1:47 ` Arnaldo Carvalho de Melo
2003-06-02 2:34 ` chas williams
2003-06-02 13:50 ` Alan Cox
2003-06-02 1:32 ` David S. Miller
2003-05-29 18:08 ` chas williams
2003-05-29 18:34 ` Arnaldo Carvalho de Melo
2003-05-30 3:01 ` David S. Miller
2003-05-30 8:57 ` Dave Jones [this message]
2003-05-30 13:36 ` Jeff Garzik
2003-05-30 13:46 ` chas williams
2003-05-30 14:00 ` chas williams
[not found] ` <200305301431.h4UEVesG003572@ginger.cmf.nrl.navy.mil>
2003-06-04 4:51 ` David S. Miller
2003-06-01 22:42 ` Francois Romieu
2003-06-18 21:08 ` chas williams
2003-06-19 1:05 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030530085726.GA14723@suse.de \
--to=davej@codemonkey.org.uk \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox