public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: Rob van Nieuwkerk <robn@verdi.et.tudelft.nl>,
	root@chaos.analogic.com, linux-kernel@vger.kernel.org,
	Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Re: 2.4 bug: fifo-write causes diskwrites to read-only fs !
Date: Fri, 30 May 2003 15:58:20 +0100	[thread overview]
Message-ID: <20030530155820.A11144@infradead.org> (raw)
In-Reply-To: <20030530132112.GA9572@redhat.com>; from sct@redhat.com on Fri, May 30, 2003 at 02:21:12PM +0100

On Fri, May 30, 2003 at 02:21:12PM +0100, Stephen C. Tweedie wrote:
> +void update_mctime (struct inode *inode)
> +{
> +	if (inode->i_mtime == CURRENT_TIME && inode->i_ctime == CURRENT_TIME)
> +		return;
> +	if ( IS_RDONLY (inode) ) return;
> +	inode->i_ctime = inode->i_mtime = CURRENT_TIME;
> +	mark_inode_dirty (inode);
> +}   /*  End Function update_mctime  */
> +

Yikes, this looks like devfs code!  Please try to use proper kernel style..


  reply	other threads:[~2003-05-30 14:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-28 17:58 2.4 bug: fifo-write causes diskwrites to read-only fs ! Rob van Nieuwkerk
2003-05-28 18:52 ` Rob van Nieuwkerk
2003-05-28 19:17   ` Richard B. Johnson
2003-05-28 19:34     ` Rob van Nieuwkerk
2003-05-28 20:22       ` Richard B. Johnson
2003-05-28 20:52         ` Rob van Nieuwkerk
2003-05-30 13:21           ` Stephen C. Tweedie
2003-05-30 14:58             ` Christoph Hellwig [this message]
2003-05-30 15:18               ` Stephen C. Tweedie
2003-05-30 16:36                 ` Andrew Morton
2003-05-28 19:22 ` Nuno Silva
2003-05-28 19:37   ` Rob van Nieuwkerk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030530155820.A11144@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=robn@verdi.et.tudelft.nl \
    --cc=root@chaos.analogic.com \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox