public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Andrew Morton <akpm@digeo.com>, Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: [patch] 2.5.70-mm3: sdla.c doesn't compile
Date: Sat, 31 May 2003 15:56:10 +0200	[thread overview]
Message-ID: <20030531135610.GI2536@fs.tum.de> (raw)
In-Reply-To: <20030531013716.07d90773.akpm@digeo.com>

It seems the following compile error when trying to compile sdla,c 
statically into the kernel comes from Linus' tree:

<--  snip  -->

...
  CC      drivers/net/wan/sdla.o
drivers/net/wan/sdla.c: In function `sdla_cmd':
drivers/net/wan/sdla.c:443: warning: comparison of distinct pointer 
types lacks a cast
drivers/net/wan/sdla.c: In function `exit_sdla':
drivers/net/wan/sdla.c:1685: `sdla0' undeclared (first use in this 
function)
drivers/net/wan/sdla.c:1685: (Each undeclared identifier is reported 
only once
drivers/net/wan/sdla.c:1685: for each function it appears in.)
make[3]: *** [drivers/net/wan/sdla.o] Error 1

<--  snip  -->


I'm not sure whether the following is the best solution but it fixes the 
problem:


--- linux-2.5.70-mm3/drivers/net/wan/sdla.c.old	2003-05-31 15:49:52.000000000 +0200
+++ linux-2.5.70-mm3/drivers/net/wan/sdla.c	2003-05-31 15:50:39.000000000 +0200
@@ -1662,12 +1662,10 @@
 	return 0;
 }
 
-#ifdef MODULE
 static struct net_device sdla0 = {
 	.name = "sdla0",
 	.init = sdla_init
 };
-#endif /* MODULE */
 
 static int __init init_sdla(void)
 {



cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2003-05-31 13:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-31  8:37 2.5.70-mm3 Andrew Morton
2003-05-31 13:56 ` Adrian Bunk [this message]
2003-05-31 14:07   ` [patch] 2.5.70-mm3: sdla.c doesn't compile Christoph Hellwig
2003-05-31 14:09 ` 2.5.70-mm3: LVM/device-mapper seems broken Sean Neakums
2003-05-31 14:18   ` Christophe Saout
2003-05-31 15:01     ` Sean Neakums
2003-05-31 15:11       ` Sean Neakums
2003-05-31 21:07 ` [patch] 2.5.70-mm3: usb_gadget_* several times defined Adrian Bunk
2003-05-31 23:41   ` David Brownell
2003-05-31 22:02 ` 2.5.70-mm3 Jordan Breeding
2003-06-02  9:17 ` 2.5.70-mm3 Alistair J Strachan
2003-06-02  9:29   ` 2.5.70-mm3 Andrew Morton
2003-06-02 10:06     ` 2.5.70-mm3 Alistair J Strachan
2003-06-03 16:51 ` 2.5.70-mm3 Mingming Cao
2003-06-03 17:39   ` 2.5.70-mm3 Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030531135610.GI2536@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=akpm@digeo.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox