From: Larry McVoy <lm@bitmover.com>
To: Steven Cole <elenstev@mesatop.com>
Cc: Larry McVoy <lm@bitmover.com>,
Jonathan Lundell <linux@lundell-bros.com>,
linux-kernel@vger.kernel.org
Subject: Re: Question about style when converting from K&R to ANSI C.
Date: Sun, 1 Jun 2003 09:52:52 -0700 [thread overview]
Message-ID: <20030601165252.GD3012@work.bitmover.com> (raw)
In-Reply-To: <1054485978.19557.93.camel@spc>
> Thanks for the input. You've convinced me. When going through
> arch/ppc/xmon/xmon.c, I will leave things like the following unchanged:
>
> /* Command interpreting routine */
> static int
> cmds(struct pt_regs *excp)
> {
Great.
> My changes will be similar to the following:
>
> @@ -1837,9 +1818,7 @@
> return *lineptr++;
> }
>
> -void
> -take_input(str)
> -char *str;
> +void take_input(char *str)
> {
> lineptr = str;
> }
OK, I'm confused. You said you were convinced but then shouldn't that be
void
take_input(char *str)
{
lineptr = str;
}
??
--
---
Larry McVoy lm at bitmover.com http://www.bitmover.com/lm
next prev parent reply other threads:[~2003-06-01 16:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-01 5:56 Question about style when converting from K&R to ANSI C Steven Cole
2003-06-01 6:39 ` Arnaldo Carvalho de Melo
2003-06-01 6:43 ` Zwane Mwaikambo
2003-06-01 13:14 ` Alan Cox
2003-06-01 19:10 ` Zwane Mwaikambo
2003-06-01 13:26 ` Larry McVoy
2003-06-01 13:49 ` Willy Tarreau
2003-06-01 14:06 ` Larry McVoy
2003-06-01 14:22 ` Willy Tarreau
2003-06-01 15:02 ` Steven Cole
2003-06-01 15:09 ` Larry McVoy
2003-06-01 15:50 ` Steven Cole
2003-06-01 16:02 ` Larry McVoy
2003-06-01 16:18 ` Steven Cole
2003-06-01 23:01 ` Paul Mackerras
2003-06-01 23:30 ` Steven Cole
2003-06-03 3:29 ` Robert White
2003-06-01 16:04 ` Jonathan Lundell
2003-06-01 16:11 ` Larry McVoy
2003-06-01 16:46 ` Steven Cole
2003-06-01 16:52 ` Larry McVoy [this message]
2003-06-01 17:18 ` Steven Cole
2003-06-02 12:39 ` Jesse Pollard
2003-06-03 3:15 ` Robert White
2003-06-01 13:53 ` Scott Robert Ladd
2003-06-02 2:09 ` Linus Torvalds
2003-06-02 2:21 ` Larry McVoy
2003-06-02 2:26 ` Davide Libenzi
2003-06-02 3:15 ` Steven Cole
2003-06-02 15:54 ` Erik Hensema
2003-06-03 12:32 ` Martin Waitz
2003-06-03 12:45 ` Dave Jones
2003-06-03 12:51 ` Jörn Engel
2003-06-03 13:18 ` Henning P. Schmiedehausen
2003-06-03 13:27 ` Richard B. Johnson
2003-06-03 13:39 ` William Lee Irwin III
2003-06-03 14:44 ` Henning Schmiedehausen
2003-06-03 15:16 ` William Lee Irwin III
2003-06-03 15:25 ` Randy.Dunlap
2003-06-03 15:38 ` William Lee Irwin III
2003-06-03 15:40 ` Randy.Dunlap
[not found] <20030601060013$0d74@gated-at.bofh.it>
[not found] ` <20030601134006$4765@gated-at.bofh.it>
[not found] ` <20030602022006$78ca@gated-at.bofh.it>
[not found] ` <20030602160025$70e8@gated-at.bofh.it>
2003-06-02 16:09 ` Pascal Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030601165252.GD3012@work.bitmover.com \
--to=lm@bitmover.com \
--cc=elenstev@mesatop.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@lundell-bros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox