public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chris@wirex.com>
To: Greg KH <greg@kroah.com>
Cc: Adrian Bunk <bunk@fs.tum.de>, linux-kernel@vger.kernel.org
Subject: Re: [2.5 patch] SECURITY_ROOTPLUG must depend on USB
Date: Mon, 2 Jun 2003 14:13:16 -0700	[thread overview]
Message-ID: <20030602141316.A15203@figure1.int.wirex.com> (raw)
In-Reply-To: <20030602172016.GB4992@kroah.com>; from greg@kroah.com on Mon, Jun 02, 2003 at 10:20:16AM -0700

* Greg KH (greg@kroah.com) wrote:
> On Sun, Jun 01, 2003 at 08:44:36PM +0200, Adrian Bunk wrote:
> > The following patch lets SECURITY_ROOTPLUG depend on USB (otherwise
> > there are link errors since Root Plug Support needs
> > usb_bus_list{,_lock}):
> 
> Applied, thanks.

While we're at it, here's a tiny cleanup for a compile warning from John
Cherry's build stats[1].  You may have a cleaner way you'd rather handle
this.

  CC [M]  security/root_plug.o
security/root_plug.c:57:1: warning: "dbg" redefined
In file included from security/root_plug.c:30:
include/linux/usb.h:979:1: warning: this is the location of the previous definition

thanks,
-chris

[1] http://www.osdl.org/archive/cherry/stability/linux-2.5.69.results/2.5.69.allmodconfig.modules.txt
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

===== security/root_plug.c 1.2 vs edited =====
--- 1.2/security/root_plug.c	Wed Dec 18 15:09:26 2002
+++ edited/security/root_plug.c	Mon Jun  2 11:42:21 2003
@@ -54,6 +54,9 @@
 #define MY_NAME "root_plug"
 #endif
 
+#ifdef dbg
+#undef dbg
+#endif
 #define dbg(fmt, arg...)					\
 	do {							\
 		if (debug)					\

  reply	other threads:[~2003-06-02 21:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-01 18:44 [2.5 patch] SECURITY_ROOTPLUG must depend on USB Adrian Bunk
2003-06-02 17:20 ` Greg KH
2003-06-02 21:13   ` Chris Wright [this message]
2003-06-02 21:40     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030602141316.A15203@figure1.int.wirex.com \
    --to=chris@wirex.com \
    --cc=bunk@fs.tum.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox